Closed Bug 328903 Opened 18 years ago Closed 18 years ago

Image requests need to cancel properly

Categories

(Core :: Graphics: ImageLib, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: roc, Assigned: darin.moz)

References

Details

Attachments

(1 file)

See https://bugzilla.mozilla.org/show_bug.cgi?id=328684#c20

Image loading needs to do something to ensure that the proper channel is cancelled if there's a redirect.
Severity: normal → major
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.9alpha
Attached patch v1 patchSplinter Review
Use a load group! :)
Attachment #214636 - Flags: superreview?(bzbarsky)
Attachment #214636 - Flags: review?(cbiesinger)
Blocks: 89419
Comment on attachment 214636 [details] [diff] [review]
v1 patch

Nice.
Attachment #214636 - Flags: superreview?(bzbarsky) → superreview+
Comment on attachment 214636 [details] [diff] [review]
v1 patch

imgRequest.cpp
+  NS_ASSERTION(aRequest, "imgRequest::Init -- No channel");

(shouldn't this say "No request"?)

might want to also assert that there's a uri
Attachment #214636 - Flags: review?(cbiesinger) → review+
good suggestion biesi.  fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
um, please don't check in to imagelib without moa=
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 214636 [details] [diff] [review]
v1 patch

pav, sorry.. that's why I cc'd you.. so you could see the patch, etc.
Attachment #214636 - Flags: review?(pavlov)
The patch is still in the tree.  Marking fixed.
Status: REOPENED → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → FIXED
Attachment #214636 - Flags: review?(pavlov) → review+
Depends on: 373701
So... why was it OK to remove the OnStopRequest/OnStartRequest stuff in imgRequest?  There was a nice comment explaining why that code was needed; why did we get rid of it in spite of that?  What replaces it?

My best guess is that this change is causing bug 373701.
And indeed, it did.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: