328925 - Replace NS_WARN_IF_FALSE with NS_ASSERTION (where appropriate)

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P1)

Description

[Darin Fisher]

Replace NS_WARN_IF_FALSE with NS_ASSERTION (where appropriate)

Bug 305987 changed NS_WARN_IF_FALSE to emit a NS_WARNING instead of a NS_ERROR.  This may not be what was intended by some authors who used NS_WARN_IF_FALSE in their code.  Since we cannot know for sure what was originally intended, we should assume that NS_ERROR was intended.  We can always revert back to warnings on a case-by-case basis if that proves to be desired.

If we don't do this then balsa may not turn orange when it would otherwise have turned orange prior to the patch for bug 305987, and then we might miss out on some valuable information.

Comment 1

[Darin Fisher]

Attachment: v1 patch

Blindly change all uses of NS_WARN_IF_FALSE to NS_ASSERTION.

1) Get list of NS_WARN_IF_FALSE users from LXR
2) cat list | xargs perl -pi -e "s/NS_WARN_IF_FALSE/NS_ASSERTION/"
3) Verify by inspection that only expected changes were made

Comment 2

[Brendan Eich [:brendan]]

Sorry I didn't review -- still trying to recover from my disk disaster.

/be

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 214248 [details] [diff] [review]
v1 patch

r=dbaron, although this did mess up the indentation in some cases

Comment 4

[Darin Fisher]

OK, I will look into fixing the indentation.  Thanks for noticing.

Comment 5

[Darin Fisher]

I fixed up the whitespace, and I killed some of the conversions where I saw fit (i.e., in Necko and XForms).