328946 - Empty <table> causes "ASSERTION: Must only be called on reflowed lines"

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Jesse Ruderman]

An empty <table> causes:

###!!! ASSERTION: Must only be called on reflowed lines: '!(GetStateBits() & NS_FRAME_IS_DIRTY)', file /Users/admin/trunk/mozilla/layout/generic/nsFrame.cpp, line 3534

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Frank Wein [:mcsmurf]]

This is probably a regression introduced sometime in the last 7 days. My debug build from 20060223 did not show this assertion, now i rebuilt and i see the assertion, too (Win2k, SeaMonkey trunk).

Comment 3

[Frank Wein [:mcsmurf]]

Ok, ignore me, this assertion is new in code, so of course no regression...

Comment 4

[Jesse Ruderman]

CCing roc since he added this assertion.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

We call CachedIsEmpty from PlaceBlock() ... the frame has been reflowed, but it's still marked dirty because we haven't determined its final position and called FinishReflowChild on it yet. Mark it dirty early to indicate that it really is OK.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 213849 [details] [diff] [review]
fix

This scares me a little, especially since I'm checking this bit more on the reflow branch, but I suppose this should be ok.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.

Comment 8

[Jesse Ruderman]

Crashtest checked in.