Re-enable favicon expiration checks

RESOLVED FIXED in Firefox 2 alpha2

Status

()

Firefox
Bookmarks & History
P2
normal
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: Brett Wilson, Assigned: Brett Wilson)

Tracking

({fixed1.8.1})

Trunk
Firefox 2 alpha2
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

13 years ago
I believe we're wasting a lot of time loading favicons into the database. I think we should uncomment the code in nsFaviconService::SetAndLoadFaviconForPage so that we don't reload favicons until they expire. This way, we will not have to load the favicon (probably from the cache, but still...) and stuff it into the database.

I suggest we should force an upper bound of like a week for favicon expiration. That way if you get a bad favicon and the site fixes it, the favicon will eventually get fixed. This might be necessary because we don't really know from the cache whether it's been force-reloaded, etc.
(Assignee)

Updated

13 years ago
Priority: -- → P2
Target Milestone: --- → Firefox 2 alpha2
(Assignee)

Comment 1

13 years ago
Fixed by bug 327841 on branch and trunk
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.