Closed
Bug 329125
Opened 19 years ago
Closed 19 years ago
Remove nsMutationEvent::mTarget
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file, 1 obsolete file)
|
11.21 KB,
patch
|
Details | Diff | Splinter Review |
Bug 234455 moves target from nsDOMEvent to nsEvent and so
nsMutationEvent::mTarget can be removed.
|
Assignee | |
Comment 1•19 years ago
|
||
Target is set in nsEventDispatcher::Dispatch so no need to explicitly set it in
Mutation event ctor and carry that extra member in nsMutationEvent.
Btw, should sicking review these patches - he is anyway in WebAPI WG ;)
Assignee: events → smaug
Status: NEW → ASSIGNED
Attachment #214457 -
Flags: superreview?(bzbarsky)
Attachment #214457 -
Flags: review?(bzbarsky)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 214457 [details] [diff] [review]
proposed patch
>Index: events/src/nsDOMMutationEvent.cpp
>+ mEventIsInternal = aEvent ? PR_FALSE : PR_TRUE;
How about:
mEventIsInternal = (aEvent == nsnull);
so there's no branch involved?
r+sr=bzbarsky with that.
Attachment #214457 -
Flags: superreview?(bzbarsky)
Attachment #214457 -
Flags: superreview+
Attachment #214457 -
Flags: review?(bzbarsky)
Attachment #214457 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Attachment #214457 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•19 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•