329130 - XML Parsing Error: undefined entity while opening about: page on builds without --enable-official-branding

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Valdis Kletnieks]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060224 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060224 Firefox/1.6a1

I have the start page set to about: so I can easily tell I've gotten the version I'm expecting (I update to latest nightly build 2-3 times a week).  Today's (2006/03/02) bombs out with this error msg:

XML Parsing Error: undefined entity
Location: jar:file:///usr/local/firefox/chrome/toolkit.jar!/content/global/about.xhtml
Line Number 82, Column 1:
<a id="mozlink" href="&releaseBaseURL;1.6a1.html">&brandShortName; 1.6a1</a>
^

and things go downhill rapidly from there (history and bookmarks fail to be found, so the 'Go' and 'Bookmarks' menus are essentially empty.

The 2006/02/24 build I'm running now works fine.  The actual history and bookmarks are still there and intact, so presumably it's all an error cascade from the same root cause of XML parsing issues.

Reproducible: Always

Comment 1

[Ria Klaassen (not reading all bugmail)]

I see also the error on WinXP, latest trunk.
It appeared for the first time between 1.9a1_2006022414 and 1.9a1_2006022423.

Comment 2

[Nickolay_Ponomarev]

Attachment: update brand.dtd used for builds without --enable-official-branding

Regression from bug 318991.

Comment 3

[Ria Klaassen (not reading all bugmail)]

*** Bug 329753 has been marked as a duplicate of this bug. ***

Comment 4

[Ria Klaassen (not reading all bugmail)]

*** Bug 329899 has been marked as a duplicate of this bug. ***

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 214127 [details] [diff] [review]
update brand.dtd used for builds without --enable-official-branding

r=me

Comment 6

[Gopal Venkatesan]

The patch works.

------------------------- Output of about: -------------------------------




Deer Park


Deer Park 1.5

Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.8) Gecko/20060311 Firefox/1.5




    * Copyright © 1998-2005 by its contributors
        according to terms set out in the
        Mozilla Public License and Netscape Public Licensedocument. All Rights Reserved.

    * Portions of this software are copyright © 1994 The Regents of the 
      University of California.  All Rights Reserved.

    * This software may contain portions that are copyright © 1998-2002 
      SupportSoft, Inc.  All Rights Reserved.




U.S. GOVERNMENT END USERS. The Software is a "commercial
item," as that term is defined in 48 C.F.R. 2.101 (Oct. 1995), consisting
of "commercial computer software" and "commercial computer software 
documentation," as such terms are used in 48 C.F.R. 12.212 (Sept. 1995). 
Consistent with 48 C.F.R. 12.212 and 48 C.F.R. 227.7202-1 through 227.7202-4
(June 1995), all U.S. Government End Users acquire the Software with only 
those rights set forth herein.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/locales/en-US/chrome/branding/brand.dtd 	1.4

Comment 8

[Marek Stępień [:marcoos, inactive]]

Comment on attachment 214127 [details] [diff] [review]
update brand.dtd used for builds without --enable-official-branding

+<!ENTITY  releaseBaseURL        "http://www.mozilla.org/projects/deerpark/releases/">

Why this? Trunk is not Deer Park...

Comment 9

[bugzilla]

Attachment: update brand.dtd for the 1.8 Branch

The 1.8 Branch is affected by this bug also.

Comment 10

[Nickolay_Ponomarev]

(In reply to comment #8)
> Why this? Trunk is not Deer Park...
> 
Re-branding is a separate issue which I didn't want deal with.

Comment 11

[Steffen Wilberg]

You don't need another review since this is basically the same patch.
And please request approval-branch-1.8.1 from someone particular.

Comment 12

[Nickolay_Ponomarev]

Could someone check this one into 1.8 branch, please (Gavin?)

Comment 13

[Steffen Wilberg]

Checking in browser/locales/en-US/chrome/branding/brand.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/branding/brand.dtd,v  <--  brand.dtd
new revision: 1.3.2.2; previous revision: 1.3.2.1