Closed
Bug 329131
Opened 18 years ago
Closed 18 years ago
Duplicated OS name when images off/screen reader etc.
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: me, Assigned: cameron)
References
()
Details
Attachments
(1 file)
998 bytes,
patch
|
morgamic
:
first-review+
|
Details | Diff | Splinter Review |
I didn't notice this when I filed Bug 328828 but the alt text on the moreinfo.php page doesn't read very well when images are off, for example from the source of the URL (ignoring Bug 328828): <p class="requires">Requires: Firefox: 1.0 - 1.5.0.* <img src="../images/firefox_icon.png" alt="Firefox" height="34" width="34"> on Windows <img src="../images/windows_icon.png" alt="Windows" border="0" height="34" width="34"></p> This displays as the following text when images are off/with a screen reader/etc: Requires: Firefox: 1.0 - 1.5.0.* Firefox on Windows Windows Perhaps it could be reworked to something like: Requires: <img src="../images/firefox_icon.png" alt="Firefox"> 1.0 - 1.5.0.* on <img src="../images/windows_icon.png" alt="Windows"> Or alternatively: Requires: <img src="../images/firefox_icon.png" alt="">Firefox 1.0 - 1.5.0.* on <img src="../images/windows_icon.png" alt="">Windows
I agree that we should have empty alt tags in this situation.
Severity: trivial → minor
Target Milestone: 1.0 → 2.1
Version: unspecified → 2.0
It appears we no longer use the OS images.
Attachment #218149 -
Flags: first-review?(morgamic)
Updated•18 years ago
|
Attachment #218149 -
Flags: first-review?(morgamic) → first-review+
Comment 3•18 years ago
|
||
Thanks Cameron -- committed.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: 2.1 → ---
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•