Duplicated OS name when images off/screen reader etc.

RESOLVED FIXED

Status

--
minor
RESOLVED FIXED
13 years ago
3 years ago

People

(Reporter: smrank, Assigned: cameron)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
I didn't notice this when I filed Bug 328828 but the alt text on the moreinfo.php page doesn't read very well when images are off, for example from the source of the URL (ignoring Bug 328828):

<p class="requires">Requires: Firefox: 1.0 - 1.5.0.* <img src="../images/firefox_icon.png" alt="Firefox" height="34" width="34"> on Windows <img src="../images/windows_icon.png" alt="Windows" border="0" height="34" width="34"></p>

This displays as the following text when images are off/with a screen reader/etc:

Requires: Firefox: 1.0 - 1.5.0.* Firefox on Windows Windows

Perhaps it could be reworked to something like:

Requires: <img src="../images/firefox_icon.png" alt="Firefox"> 1.0 - 1.5.0.* on <img src="../images/windows_icon.png" alt="Windows">

Or alternatively:

Requires: <img src="../images/firefox_icon.png" alt="">Firefox 1.0 - 1.5.0.* on <img src="../images/windows_icon.png" alt="">Windows

Comment 1

13 years ago
I agree that we should have empty alt tags in this situation.  
Severity: trivial → minor
Target Milestone: 1.0 → 2.1
Version: unspecified → 2.0
(Assignee)

Updated

13 years ago
Assignee: morgamic → em6icu202
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

13 years ago
Created attachment 218149 [details] [diff] [review]
Remove application image alt text

It appears we no longer use the OS images.
Attachment #218149 - Flags: first-review?(morgamic)
Attachment #218149 - Flags: first-review?(morgamic) → first-review+
Thanks Cameron -- committed.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Target Milestone: 2.1 → ---
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.