Closed
Bug 329140
Opened 19 years ago
Closed 19 years ago
fixup use of cflags/defines
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(2 files)
|
4.74 KB,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
|
838 bytes,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
Some makefiles aren't using MOZ_CAIRO_CFLAGS even though they should, because the code includes cairo headers. This is mostly an issue when system-cairo is used.
the patch here also includes a few other minor things.
this is part of the work to make cairo-beos work.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #213784 -
Flags: review?(vladimir)
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
Attachment #213784 -
Flags: review?(vladimir) → review+
|
|
Assignee | |
Comment 2•19 years ago
|
||
this additional patch makes layout/build link to libcairo when needed (that is, when cairo gfx is enabled, and when using an out of tree cairo. in such a case, thebes doesn't contain cairo, so we need to link with the system cairo.)
Attachment #213790 -
Flags: review?(vladimir)
|
|
Assignee | |
Comment 3•19 years ago
|
||
Comment on attachment 213784 [details] [diff] [review]
patch (checked in)
this patch is now checked in on trunk, leaving open for the other one
Attachment #213784 -
Attachment description: patch → patch (checked in)
Attachment #213790 -
Flags: review?(vladimir) → review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Checking in layout/build/Makefile.in;
/cvsroot/mozilla/layout/build/Makefile.in,v <-- Makefile.in
new revision: 1.137; previous revision: 1.136
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•