Closed Bug 329156 Opened 18 years ago Closed 18 years ago

Updater should fail rather than report success when update.manifest is empty

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1alpha2

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

patch v1.0
810 bytes, patch
darin.moz
: review+
darin.moz
: approval-branch-1.8.1+
Details | Diff | Splinter Review 
From bug 327140 it became apparent that the updater reports success when processing an empty update.manifest file that is unpacked from a bad mar file. In essence this is correct behavior as the updater has done what it is supposed to do (nothing). A failure in this case is more useful so that the user is notified and a different update can be downloaded/applied. Patch coming up.
Attached patch patch v1.0 — — Splinter Review 
Here's the patch for the trunk.
Attachment #213801 - Flags: review?(darin)
Comment on attachment 213801 [details] [diff] [review]
patch v1.0

r=darin
Attachment #213801 - Flags: review?(darin) → review+
Oops, how about we get this in for alpha1?
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 2 alpha1
Comment on attachment 213801 [details] [diff] [review]
patch v1.0

a=darin for landing this on the MOZILLA_1_8_BRANCH.  please add keyword fixed1.8.1 when the fix has been checked in on the branch.
Attachment #213801 - Flags: approval-branch-1.8.1+
fixed on branch
Keywords: fixed1.8.1
fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 2 alpha1 → Firefox 2 alpha2
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: