If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

No 'settings' template case in generic auth code

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
Administration
--
minor
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Vlad Dascalu, Assigned: Vlad Dascalu)

Tracking

2.20.1
Bugzilla 2.20
Bug Flags:
approval +
approval2.22 +
approval2.20 +

Details

(URL)

Attachments

(1 attachment)

735 bytes, patch
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
https://bugzilla.mozilla.org/editsettings.cgi reports:

>>  Sorry, you aren't a member of the 'tweakparams' group, and so you are not authorized to modify . <<

(for non-bmo admins)

In editsettings.cgi we actually do:

$user->in_group('tweakparams')
  || ThrowUserError("auth_failure", {group  => "tweakparams",
                                     action => "modify",
                                     object => "settings"});

but we have no 'settings' case in the user-error.html.tmpl template. Looks like we must modify it, since reusing 'parameters' would be kind of inappropiate.
(Assignee)

Updated

12 years ago
Assignee: administration → vladd
(Assignee)

Comment 1

12 years ago
Created attachment 213810 [details] [diff] [review]
Version 1
Attachment #213810 - Flags: review?

Comment 2

12 years ago
Comment on attachment 213810 [details] [diff] [review]
Version 1

looks good. r=LpSolit
Attachment #213810 - Flags: review? → review+
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval2.22?
Flags: approval2.20?

Updated

12 years ago
Severity: normal → minor
Version: unspecified → 2.20.1
Flags: approval?
Flags: approval2.22?
Flags: approval2.22+
Flags: approval2.20?
Flags: approval2.20+
Flags: approval+
(Assignee)

Comment 3

12 years ago
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.154; previous revision: 1.153
done

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.145.2.2; previous revision: 1.145.2.1
done

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.115.2.10; previous revision: 1.115.2.9
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.