329203 - [BeOS] Places toolbar does not show bookmarks

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P1)

Description

[Doug Shelton]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060225 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060225 Firefox/1.6a1

Places toolbar displays places icon but no bookmarks.  This used to work (when places was first enabled).  I tried running --profilemanager and creating a clean profile but still no luck.

Reproducible: Always

Steps to Reproduce:
1.Start Firefox
2.display places toolbar
3.observe lack of bookmarks on toolbar

Actual Results:  
no bookmarks on toolbar

Expected Results:  
bookmarks and icons should show on toolbar

Comment 1

[Doug Shelton]

Attachment: screenshot of browser with missing bookmarks

Comment 2

[Ria Klaassen (not reading all bugmail)]

See Bug 329100 and 328299.

Comment 3

[Doug Shelton]

(In reply to comment #2)
> See Bug 329100 and 328299.
> 
Comment in 329100 implies carryover of .rdf from previous build.  In this instance, I see the same behavior even when creating a new profile, so maybe this is a different variation on the problem.

Comment 4

[Doug Shelton]

I'm working with a debug build.  I started Firefox and saw a javascript error as the main window opened.  Clicking on the places toolbar generated a javascript error with each click.  I hope this helps:
++DOMWINDOW == 5
Note: verifyreflow is disabled
++DOMWINDOW == 6
JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsIDocShellHistory.useGlobalHistory]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "JS frame :: chrome://browser/content/browser.js :: prepareForStartup :: line 721"  data: no]
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file /boot/home/develop/mozilla/toolkit/components/history/src/nsGlobalHistory.cpp, line 2627
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file /boot/home/develop/mozilla/toolkit/components/history/src/nsGlobalHistory.cpp, line 2627
JavaScript error: chrome://browser/content/places/toolbar.xml, line 645: this.getResult() has no properties
JavaScript error: chrome://browser/content/places/toolbar.xml, line 645: this.getResult() has no properties
JavaScript error: chrome://browser/content/places/toolbar.xml, line 645: this.getResult() has no properties
JavaScript error: chrome://browser/content/places/toolbar.xml, line 645: this.getResult() has no properties
                                                                                                              

Comment 5

[Brett Wilson]

Something is messed up with your build, nsGlobalHistory.cpp shouldn't be getting compiled at all. In toolkit/components/ is has a condition on MOZ_PLACES for the 'src' directory. Either this somehow doesn't work for BeOS or your build needs cleaning.

Comment 6

[Brett Wilson]

I meant toolkit/components/history/Makefile.in in the previous post.

Comment 7

[Doug Shelton]

(In reply to comment #6)
> I meant toolkit/components/history/Makefile.in in the previous post.
> 
It looks like the flag is present in this file.  I shall completely delete my output directory and rebuild.  We'll see if that fixes it, else we may have another BeOS gremlin.

Comment 8

[Doug Shelton]

deleting output directory, rebuilding then starting with a clean profile fixed this problem, so there was definitely a build issue.  However, starting with my existing profile, items are still missing.  Further, the "file/import" option did not import bookmarks from my other profile, either.  Suggestions?

Comment 9

[Brett Wilson]

I filed bug 329343 for the File|Import menu needing to be hooked up with places.

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv