sidebar.xul.tmpl generates version info in output .html

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Bugzilla-General
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

2.16.11
Bugzilla 3.0
Bug Flags:
approval +

Details

Attachments

(3 attachments)

(Assignee)

Description

12 years ago
[% template_version = "1.0@bugzilla.org" %] should be [%# 1.0@bugzilla.org %]
(Assignee)

Comment 1

12 years ago
Created attachment 213940 [details] [diff] [review]
patch for 2.20 - 2.23, v1
Attachment #213940 - Flags: review?(vladd)
(Assignee)

Comment 2

12 years ago
Created attachment 213941 [details] [diff] [review]
patch for 2.18, v1
Attachment #213941 - Flags: review?(vladd)
(Assignee)

Comment 3

12 years ago
Created attachment 213942 [details] [diff] [review]
patch for 2.16, v1
Attachment #213942 - Flags: review?(vladd)

Comment 4

12 years ago
We kind of sorted this out in bug 329295 (tinderbox was failing due to this and now we know why).

But nevertheless, we can still apply those changes if we want to -- we used to have the template version in HTML, and 1.0@bugzilla.org received all the spam in the world :) Today we kind of keep the version in the .tmpl files only.
Assignee: general → LpSolit

Updated

12 years ago
Attachment #213940 - Flags: review?(vladd) → review+

Comment 5

12 years ago
Comment on attachment 213941 [details] [diff] [review]
patch for 2.18, v1

Not sure if it makes sense to do that on locked-down branches, but david/myk will decide that.
Attachment #213941 - Flags: review?(vladd) → review+

Updated

12 years ago
Attachment #213942 - Flags: review?(vladd) → review+

Updated

12 years ago
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval2.22?
Flags: approval2.20?
Flags: approval2.18?
Flags: approval2.16?
Summary: sidebar.xul.tmpl has a bad header → sidebar.xul.tmpl generates version info in output .html
This doesn't seem like the kind of thing we need to fix in earlier releases, but cc:ing Dave for his opinion.
Flags: approval? → approval+
(Assignee)

Comment 7

12 years ago
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.66; previous revision: 1.65
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Flags: approval2.22?
Flags: approval2.20?
Flags: approval2.18?
Flags: approval2.16?
Resolution: --- → FIXED
Target Milestone: Bugzilla 2.16 → Bugzilla 2.24
You need to log in before you can comment on or make changes to this bug.