Closed Bug 329295 Opened 19 years ago Closed 19 years ago

008filter fails if . is not in PATH

Categories

(Bugzilla :: Testing Suite, defect)

2.16.11
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: goobix, Assigned: goobix)

Details

Attachments

(2 files, 4 obsolete files)

008filter could fail if . is not in PATH, because in that case Find::File will include './' at the beginning of the file name, and filterexceptions.pl doesn't have that.
Assignee: zach → vladd
Attached patch 2.16 patch, v1 (obsolete) — Splinter Review
Attachment #213949 - Flags: review?(LpSolit)
Attached patch 2.18 or newer, v1 (obsolete) — Splinter Review
Attachment #213950 - Flags: review?(LpSolit)
And for some reason this only fails with TT 2.08 and perl 5.6.x.
Status: NEW → ASSIGNED
Version: unspecified → 2.16
Nit: . should be \. I'll fix upon checkin. Mkanat: not true, I can reproduce it with: bash-2.05b$ perl -v This is perl, v5.8.7 built for i686-linux
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Version: 2.16 → unspecified
Oops.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Comment on attachment 213949 [details] [diff] [review] 2.16 patch, v1 >+ # Make sure we're not looking for ./ in the $safe hash >+ $file=~s#^./##; Please also add whitespaces around = $file =~ s#^\./##; Assuming you have tested it and you will fix that on checkin, r=LpSolit.
Attachment #213949 - Flags: review?(LpSolit) → review+
Attached patch 2.16 patch, v2, tested (obsolete) — Splinter Review
The same as v1, but with . -> \.
Attachment #213949 - Attachment is obsolete: true
Attachment #213952 - Flags: review?(LpSolit)
Comment on attachment 213950 [details] [diff] [review] 2.18 or newer, v1 >+ # Make sure we're not looking for ./ in the $safe hash >+ $file=~s#^./##; Same comment as before. r=LpSolit
Attachment #213950 - Flags: review?(LpSolit) → review+
Attached patch 2.18 or newer, v2, tested (obsolete) — Splinter Review
Same for 2.18 or newer.
Attachment #213950 - Attachment is obsolete: true
Attachment #213953 - Flags: review?(LpSolit)
Comment on attachment 213952 [details] [diff] [review] 2.16 patch, v2, tested Same comment as before. r=LpSolit
Attachment #213952 - Flags: review?(LpSolit) → review+
Attachment #213952 - Attachment description: 216 patch, v2, tested → 2.16 patch, v2, tested
Attachment #213952 - Flags: review+ → review?(LpSolit)
Flags: approval?
Flags: approval2.22?
Flags: approval2.20?
Flags: approval2.18?
Flags: approval2.16?
Attachment #213952 - Attachment is obsolete: true
Attachment #213954 - Flags: review?(LpSolit)
Attachment #213952 - Flags: review?(LpSolit)
Comment on attachment 213952 [details] [diff] [review] 2.16 patch, v2, tested no midair protection on flag changes. This was a r+ :)
Attachment #213952 - Attachment is obsolete: false
Attachment #213952 - Flags: review+
Attachment #213952 - Attachment is obsolete: true
Attachment #213953 - Attachment is obsolete: true
Attachment #213955 - Flags: review?(LpSolit)
Attachment #213953 - Flags: review?(LpSolit)
Attachment #213954 - Flags: review?(LpSolit) → review+
Attachment #213953 - Attachment description: 2.18 or newev, v2, tested → 2.18 or newer, v2, tested
Attachment #213955 - Flags: review?(LpSolit) → review+
Version: unspecified → 2.16.11
Egads, we have so many supported versions.
Flags: approval?
Flags: approval2.22?
Flags: approval2.22+
Flags: approval2.20?
Flags: approval2.20+
Flags: approval2.18?
Flags: approval2.18+
Flags: approval2.16?
Flags: approval2.16+
Flags: approval+
tip: Checking in t/008filter.t; /cvsroot/mozilla/webtools/bugzilla/t/008filter.t,v <-- 008filter.t new revision: 1.23; previous revision: 1.22 done 2.22rc1: Checking in t/008filter.t; /cvsroot/mozilla/webtools/bugzilla/t/008filter.t,v <-- 008filter.t new revision: 1.21.2.1; previous revision: 1.21 done 2.20.1: Checking in t/008filter.t; /cvsroot/mozilla/webtools/bugzilla/t/008filter.t,v <-- 008filter.t new revision: 1.17.6.3; previous revision: 1.17.6.2 done 2.18.5: Checking in t/008filter.t; /cvsroot/mozilla/webtools/bugzilla/t/008filter.t,v <-- 008filter.t new revision: 1.12.2.3; previous revision: 1.12.2.2 done 2.16.11: Checking in t/008filter.t; /cvsroot/mozilla/webtools/bugzilla/t/008filter.t,v <-- 008filter.t new revision: 1.1.2.3; previous revision: 1.1.2.2 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: