Closed Bug 329304 Opened 18 years ago Closed 18 years ago

booleans are recorded as 1/0 instead of true/false

Categories

(Toolkit Graveyard :: Data Collection/Metrics, defect)

Product:
Toolkit Graveyard
Component:
Data Collection/Metrics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bryner, Assigned: bryner)

Details

Attachments

(1 file)

fix
1.39 KB, patch
Details | Diff | Splinter Review 
When we log an event, we're packing each of the event properties into an nsVariant, which is then converted to a string to set as the attribute value.  nsVariant chooses to convert booleans to "1" or "0" instead of "true" or "false", so that's what we end up with in the XML.

We can solve this by checking the datatype in the variant before asking for the string value, and having a special case for booleans.
Attached patch fix — — Splinter Review 

        Attachment #213960 -
        Flags: first-review?(marria)

    
  

        Attachment #213960 -
        Flags: first-review?(marria) → first-review+

    
    

    
  
checked in
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
  
Flags: first-review+
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: