329314 - Pressing Ctrl+Z in Places Results in an Invalid Transaction Index Error, but last action is undone

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Weston Carloss]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060303 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060303 Firefox/1.6a1

Attempting to undo actions in Places using Ctrl+Z results in an error dialog, but the action is still undone.

Reproducible: Always

Steps to Reproduce:
Try to perform an action in places, such as dragging and dropping bookmarks to reorder them.  Multiple bookmarks will probably move, even though only one bookmark was selected.  If you then hit Ctrl+Z to undo the drag and drop, an error dialog pops up that says:

ASSERT:  Invalid Transaction Index
Stack Trace:
0:PTM_undoTransaction()
1:PC_doCommand(cmd_undo)

If you then click Ok, the intended bookmark movement is still undone, while the undesired bookmark movement remains.

This error also pops up when hitting Ctrl+Z when no action was previously taken, but then there is no action to undo.

Comment 1

[Weston Carloss]

Attachment: Screenshot of Error Dialog

I've attached a screenshot of the error dialog.

Comment 2

[Weston Carloss]

Sorry for the bug spam, but I should have mentioned that I am using a Cairo enabled trunk build.

Configure arguments
--enable-application=browser --enable-update-channel=nightly --enable-optimize --disable-debug --disable-tests --enable-static --disable-shared --enable-svg --enable-canvas --enable-default-toolkit=cairo-windows --enable-update-packaging

Comment 3

[Peter van der Woude [:Peter6]]

javascript console:

Error: transaction has no properties
Source file: chrome://browser/content/browser.js
Line: 6268

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

My bet is this is fixed. REOPEN if that's not the case.

Comment 5

[Weston Carloss]

Yes, it's fixed.

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv