329323 - Some browsers might not pick up comment upon new attachment

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Vlad Dascalu]

We have a spelling in 2.20 and 2.22, "commment" instead of "comment". It was fixed on trunk by the 'zoomable textareas' thing.

Comment 1

[Vlad Dascalu]

Attachment: Patch, v1

Comment 2

[Vlad Dascalu]

Attachment: Patch, v1

Erm, wrong file.

Comment 3

[Frédéric Buclin]

wrong, what is important is the value of the name attribute. The content of the id attribute is only useful for the label field.

Comment 4

[Vlad Dascalu]

There are some old browsers that use 'name' instead of 'id' - see http://home.cogeco.ca/~ve3ll/htmlform.htm :

>> The id attribute associates a variable name with the control. The name attribute is an older (now deprecated) method of association. For compatibility set both id and name to the same variable name. <<

Comment 5

[Vlad Dascalu]

We don't need approval?, but I'm requesting it anyway in order to:

-> make this appear on the approval? query that justdave uses.
-> give a chance to approval- a bug from time to time. :)

Comment 6

[Frédéric Buclin]

2.22rc1:

Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.22.2.3; previous revision: 1.22.2.2
done

2.20.1:

Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.20.4.3; previous revision: 1.20.4.2
done