Closed Bug 329359 Opened 18 years ago Closed 15 years ago

Fieldsets don't take floating elements in their margin

Categories

(Core :: Layout: Form Controls, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jepsar, Unassigned)

References

Details

(Keywords: testcase)

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060304 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060304 Firefox/1.6a1

See testcase. I'm not sure if this isn't a duplicate of 276456

Reproducible: Always

Steps to Reproduce:
Attached file Testcase
Testcase
Keywords: testcase
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20060311 Firefox/1.6a1 ID:0000000000
Confirmed.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Still there in 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061216 Minefield/3.0a1
OS: Linux → All
Yeah, the point is that fieldset is a block formatting context root in Gecko.
Depends on: 276456
Attached patch reftestSplinter Review
This now works as expected by the reporter. And I think that's correct.
Usually the margins of block formatting roots don't behave differently than margins of normal blocks.
IE8 also renders the same as we do.

Anyway, a reftest can't hurt.
Attachment #377862 - Flags: review?(bzbarsky)
> Usually the margins of block formatting roots don't behave differently

They used to when I made comment 4.  The spec got changed.  See bug 377664 (filed after that change, 3 months after comment 4).  The fix for that is what fixed this bug too.
Depends on: 427129
Pushed test as http://hg.mozilla.org/mozilla-central/rev/ae2edbe75c32

Daniel, you might be interested in comment 6.
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Attachment #377862 - Flags: review?(bzbarsky) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: