329359 - Fieldsets don't take floating elements in their margin

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jasper de Vries]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060304 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060304 Firefox/1.6a1

See testcase. I'm not sure if this isn't a duplicate of 276456

Reproducible: Always

Steps to Reproduce:

Comment 1

[Jasper de Vries]

Attachment: Testcase

Testcase

Comment 2

[Philip Withnall (unavailable)]

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20060311 Firefox/1.6a1 ID:0000000000
Confirmed.

Comment 3

[Giorgio Maone [:ma1]]

Still there in 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061216 Minefield/3.0a1

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yeah, the point is that fieldset is a block formatting context root in Gecko.

Comment 5

[Daniel.S]

Attachment: reftest

This now works as expected by the reporter. And I think that's correct.
Usually the margins of block formatting roots don't behave differently than margins of normal blocks.
IE8 also renders the same as we do.

Anyway, a reftest can't hurt.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> Usually the margins of block formatting roots don't behave differently

They used to when I made comment 4.  The spec got changed.  See bug 377664 (filed after that change, 3 months after comment 4).  The fix for that is what fixed this bug too.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Pushed test as http://hg.mozilla.org/mozilla-central/rev/ae2edbe75c32

Daniel, you might be interested in comment 6.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Er, make that pushed as http://hg.mozilla.org/mozilla-central/rev/d84c13be7994 (silly mq).