Closed Bug 329455 Opened 20 years ago Closed 20 years ago

Printing on trunk is impossible with Cocoa widgets

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mark, Assigned: mark)

References

Details

Attachments

(2 files, 1 obsolete file)

Register moved services in the Cocoa widget factory
3.00 KB, patch
jaas
: review+
pavlov
: superreview+
Details | Diff | Splinter Review
indent, ret val and cairo-mac fix
4.04 KB, patch
pavlov
: review+
pavlov
: superreview+
Details | Diff | Splinter Review
Bug 326149 broke printing under Cocoa widgets. Nobody picked up on this until today, because Mac printing was broken anyway due to bug 326363. Files were moved from gfx into widget/src/mac in bug 326149. They are built when using Cocoa widgets by adding them to MAC_LCPPSRCS in widget/src/cocoa, but the services that moved are never registered under Cocoa widgets. nsWidgetFactory.cpp was updated in widget/src/mac, but nsWidgetFactory.mm in widget/src/cocoa never saw those changes.
Attachment #214132 - Flags: superreview?(pavlov)
Attachment #214132 - Flags: review?(joshmoz)
Attachment #214132 - Flags: review?(joshmoz) → review+
Severity: normal → critical
Whiteboard: [needs superreview pavlov]
Attachment #214132 - Flags: superreview?(pavlov) → superreview+
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: [needs superreview pavlov]
Attached patch thebes fix (obsolete) — — Splinter Review
The lack of GetSurfaceForPrinter caused a build error for cairo-cocoa/mac. (I'm not sure if this is doing the right thing as printing is still broken by other bugs for thebes)
Attachment #214531 - Flags: review?(mark)
Attachment #214531 - Flags: superreview?(pavlov)
Comment on attachment 214531 [details] [diff] [review] thebes fix I noticed this too yesterday. r=me to get Mac Cairo building again. This looks like the right thing to do, but printing is broken without a doubt anyway.
Attachment #214531 - Flags: review?(mark) → review+
Attachment #214531 - Flags: superreview?(pavlov) → superreview+
Comment on attachment 214531 [details] [diff] [review] thebes fix GetSurfaceForPrinter should just return null until things are actually hooked up to do real printing. That function should also use 4 space indentation to be consistent with the file...
Attachment #214531 - Flags: review-
Adding cairo-mac fix to Makefile.in.
Attachment #214531 - Attachment is obsolete: true
Attachment #214616 - Flags: superreview?(vladimir)
Attachment #214616 - Flags: review?(pavlov)
Comment on attachment 214616 [details] [diff] [review] indent, ret val and cairo-mac fix checked in
Attachment #214616 - Flags: superreview?(vladimir)
Attachment #214616 - Flags: superreview+
Attachment #214616 - Flags: review?(pavlov)
Attachment #214616 - Flags: review+
Comment on attachment 214616 [details] [diff] [review] indent, ret val and cairo-mac fix Uh, what's with the widget/src/mac/Makefile.in change? As far as I knew, Cairo with Carbon widgets is never going to be a working configuration.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: