329524 - nsNavBookmarks::ReplaceItem() leaves the bookmark hash in an inconsistent state

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Joe Hughes]

Using nsNavBookmarksService::ReplaceItem() to change the URI of a bookmark seems to cause problems with the bookmark hash.  The symptoms are that in the UI, the changed bookmark will believe that it still represents the old URI (causing an error if you try to view its properties), and the following message will get printed to the console:

###!!! ASSERTION: Bookmark hash table out-of-sync with the database:
'realBookmarked == *aBookmarked', file
/fb/mozilla/browser/components/places/src/nsNavBookmarks.cpp, line
1718
Break: at file /fb/mozilla/browser/components/places/src/nsNavBookmarks.cpp,
line 1718

Comment 1

[Brett Wilson]

Attachment: Patch

Comment 2

[Brett Wilson]

On trunk and branch.

Comment 3

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv