329552 - New Mail Notification Alert is only a couple pixels tall

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

03/06  trunk build.

Sometimes, when the new mail notification alert comes up, it gets a height of a pixel or so and then goes away. 

This is happening when you select an IMAP folder with new mail (as opposed to clicking get new mail or letting biff fetch new messages).

For some reason, when selecting a new folder that has new mail, we are trying to load the new mail alert. And in this scenario for some reason we don't find any new messages in the folder summary parsing object so that element has zero children. As a result our "best guess" height measurement for the window is only a couple pixels.

The fact that we are trying to bring up the alert notification when selecting a folder is an error. We should only be doing it when biff has gone off.

Comment 1

[Scott MacGregor]

Attachment: a work around

This patch causes us to not show the animated alert if we detect that we don't have any new messages in the folder summary info object, we close the alert and quit.

But now that I've done this, I think it's the wrong fix. We should figure out why the code is loading the alert window when selecting a folder with unseen messages.

Comment 2

[Scott MacGregor]

Attachment: backend imap fix

David and I came up with this fix.

Addresses two issues:

1) When starting up, if you had new mail just in the inbox, the mail alert would be broken because we didn't recognize that the inbox had new mail.

2) When selecting a folder that has new mail, the folder still had the performing biff flag selected on it, so we were calling the alert when we shouldn't be. Clear the performing biff flag when an imap folder has no new messages.

Comment 3

[Scott MacGregor]

David and I decided we wanted both of these patches. The first one fixes some issues for POP3 users who don't have the headers downloaded by default. And the second fixes the problems I was seeing with IMAP.

Comment 4

[Scott MacGregor]

this seems to still be happening for some pop3 users.

Comment 5

[PeterG]

(In reply to comment #4)
> this seems to still be happening for some pop3 users.
> 

As I posted here:

http://forums.mozillazine.org/viewtopic.php?p=2137268&highlight=#2137268

only emails from [e-mail] triggered the "new" new mail notification being a couple of pixels high. The problem was something in my training.dat. Deleting it and I received a proper notification, copying it back in again to my profile and a notification being a couple of pixels high. 100% repeatability. I am using IMAP. 

Comment 6

[Mike Cowperthwaite]

*** Bug 329635 has been marked as a duplicate of this bug. ***

Comment 7

[Scott MacGregor]

Attachment: fix for pop3 users

david helped me debug this for pop3 users. This patch should do it.

Comment 8

[Scott MacGregor]

ok, hopefully that does the trick for POP3 users.