329581 - Most observers are not removed on shutdown

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Joey Minta]

Much of the calendar code requires observers of one kind or another.  Although all components which implement an addObserver function also implement a removeObserver function, most callers do not take advantage of this.  The easy cases to fix are the front-end cases, like the views, which can just use destructors or onunload listeners to tidy up (most don't even do this!).  The tougher cases are where backend (component) code is adding observers.  These are probably going to need shutdown() methods added to them.

(possibly incomplete) list of unremoved observers:
calendar-multiday-view's mObserver
calendar-month-view's mObserver
agendaTreeView's calendarObserver
calendar-todo-list's mOperationListener
ltnCompositeCalendarObserver
ltnCalendarManagerObserver
calCalendarManagerObserver

All error-announcer observers
All helper-observers in the composite calendar
ics calendar's observer on the memory calendar

For the most part, I'm working off of http://landfill.mozilla.org/mxr-test/mozilla/search?string=addObserver&find=calendar&filter=

Comment 1

[Reed Loden [:reed]]

The bugspam monkeys have struck again. They are currently chewing on default assignees for Calendar. Be afraid for your sanity!

Comment 2

[Joey Minta]

Attachment: sunbird tested patch

I'll ask for review here once Lightning is unbroken and I can test there too.  These are some major leaks on Mac and on Firefox Lightning that I'd like to fix.

Comment 3

[Joey Minta]

Attachment: unbitrotted

Unbitrots the previous patch.  Now tested on Lightning.

Comment 4

[Matthew (lilmatt) Willis]

Comment on attachment 234954 [details] [diff] [review]
unbitrotted

Yay! Less leaking!

r1=lilmatt

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 234954 [details] [diff] [review]
unbitrotted

r=dmose

Comment 6

[Joey Minta]

patch checked in.