329595 - Crash on marking mail as Junk (Local Folders) [@ nsMsgDBView::PerformActionsOnJunkMsgs]

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[u63580]

TB version 2 alpha 1 (20060306)

Current nightly of TB 2 crashes whenever I mark a message in "Local Folders" as Junk.  After crash, message is marked as Junk, but not deleted.  I have TB set to move manually-marked Junk to the Junk folder.

Talkback ID:
TB16036150X

Comment 1

[u63580]

Also:
TB16049824H

Comment 2

[David :Bienvenu]

this is odd - I do this all the time. Have you tried a trunk build? You have a junk folder, correct?

Comment 3

[u63580]

(In reply to comment #2)
> this is odd - I do this all the time. Have you tried a trunk build? You have a
> junk folder, correct?
> 

Redownloading and installing seems to have solved the problem.  Sorry to disturb you!  

Comment 4

[u63580]

Damn, having said that, the problem has reappeared on some new junk.  New talkback:

TB16054529Z

Comment 5

[timeless]

Incident ID: 16054529
Stack Signature	nsMsgDBView::PerformActionsOnJunkMsgs 7b9c55e9
Product ID	Thunderbird2
Build ID	2006030706
Trigger Time	2006-03-07 10:37:10.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	thunderbird.exe + (00424d38)
URL visited	
User Comments	
Since Last Crash	5573 sec
Total Uptime	5573 sec
Trigger Reason	Access violation
Source File, Line No.	e:/builds/tinderbox/Tb-Mozilla1.8/WINNT_5.0_Depend/mozilla/mailnews/base/src/nsMsgDBView.cpp, line 2910
Stack Trace 	
nsMsgDBView::PerformActionsOnJunkMsgs  [e:/builds/tinderbox/Tb-Mozilla1.8/WINNT_5.0_Depend/mozilla/mailnews/base/src/nsMsgDBView.cpp, line 2910]
nsMsgDBView::OnMessageClassified  [e:/builds/tinderbox/Tb-Mozilla1.8/WINNT_5.0_Depend/mozilla/mailnews/base/src/nsMsgDBView.cpp, line 2849]
MessageObserver::analyzeTokens  [e:/builds/tinderbox/Tb-Mozilla1.8/WINNT_5.0_Depend/mozilla/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp, line 1259]
nsMsgProtocol::OnStopRequest  [e:/builds/tinderbox/Tb-Mozilla1.8/WINNT_5.0_Depend/mozilla/mailnews/base/util/nsMsgProtocol.cpp, line 392]
nsMailboxProtocol::OnStopRequest  [e:/builds/tinderbox/Tb-Mozilla1.8/WINNT_5.0_Depend/mozilla/mailnews/local/src/nsMailboxProtocol.cpp, line 395]
nsInputStreamPump::OnStateStop  [e:/builds/tinderbox/Tb-Mozilla1.8/WINNT_5.0_Depend/mozilla/netwerk/base/src/nsInputStreamPump.cpp, line 564]
0x0259cf30
nsMailboxProtocol::`vftable'
nsCMSEncoder::AddRef  [e:/builds/tinderbox/Tb-Mozilla1.8/WINNT_5.0_Depend/mozilla/security/manager/ssl/src/nsCMS.cpp, line 55]
0x8b560c45

mCommandUpdater is null checked everywhere else, but not in this code...

Comment 6

[timeless]

Attachment: possibility

Comment 7

[timeless]

Attachment: possibility

*sigh*. my tools are fighting me

Comment 8

[David :Bienvenu]

Comment on attachment 214396 [details] [diff] [review]
possibility

yes, that's a possibility - though it doesn't explain why it just started crashing...

Comment 9

[timeless]

Comment on attachment 214396 [details] [diff] [review]
possibility

mozilla/mailnews/base/src/nsMsgDBView.cpp 	1.232

Should we commit this to branches? it's a simple null check which hopefully will resolve an annoying crash

Comment 10

[Scott MacGregor]

looks like this was checked into the 1.8.1 branch and the trunk on 03/07.

Comment 11

[Jay Patel [:jay]]

Comment on attachment 214396 [details] [diff] [review]
possibility

Please check in promptly on the 1.8.0 branch.  Thanks!

Comment 12

[Bob Clary [:bc] (inactive)]

I got this with today's thunderbird2/winxp: tb17745016

nsMsgDBView::PerformActionsOnJunkMsgs  [e:/builds/tinderbox/Tb-Mozilla1.8/WINNT_5.0_Depend/mozilla/mailnews/base/src/nsMsgDBView.cpp, line 2910]
nsMsgDBView::OnMessageClassified  [e:/builds/tinderbox/Tb-Mozilla1.8/WINNT_5.0_Depend/mozilla/mailnews/base/src/nsMsgDBView.cpp, line 2849]
MessageObserver::analyzeTokens  [e:/builds/tinderbox/Tb-Mozilla1.8/WINNT_5.0_Depend/mozilla/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp, line 1259]
nsImapCacheStreamListener::OnStopRequest  [e:/builds/tinderbox/Tb-Mozilla1.8/WINNT_5.0_Depend/mozilla/mailnews/imap/src/nsImapProtocol.cpp, line 7830]
nsInputStreamPump::OnStateStop  [e:/builds/tinderbox/Tb-Mozilla1.8/WINNT_5.0_Depend/mozilla/netwerk/base/src/nsInputStreamPump.cpp, line 564]
0x07f4c78c

Comment 13

[Bob Clary [:bc] (inactive)]

Note that this was when viewing mail in window (not the preview pane) from an imap server, so it is a little different from the original case of local folders, but the stack is the same.

Comment 14

[jwq]

Cross-ref: Bug 315922 and Bug 313103 (both reported against the Core).

 These bugs also report crashes while setting/unsetting the junk flag and have (perhaps unsurprisingly) nsMsgDBView::PerformActionsOnJunkMsgs in the stack trace.

Comment 15

[timeless]

Comment on attachment 214396 [details] [diff] [review]
possibility

MOZILLA_1_8_BRANCH:
mozilla/mailnews/base/src/nsMsgDBView.cpp 	1.222.4.8

MOZILLA_1_8_0_BRANCH (mscott):
mozilla/mailnews/base/src/nsMsgDBView.cpp 	1.222.4.2.2.3

Comment 16

[Marcia Knous [:marcia]]

verified on the 1.8.0 branch using version 1.5.0.4 (20060508). Following the reporter's steps I don't see a crash marking messages as junk. Adding keyword.

Comment 17

[Ben Turner (not reading bugmail, use the needinfo flag!)]

->FIXED

Comment 18

[juan becerra [:juanb]]

Verified on Thunderbird 2 release candidate; version 2.0pre (20070307); Marking messages as junk does not crash the application. Adding verified1.8.1.3