null comptr dereference when manifest contains path with missing drive

RESOLVED WORKSFORME

Status

()

Core
XUL
RESOLVED WORKSFORME
12 years ago
9 years ago

People

(Reporter: Neil Deakin, Assigned: Neil Deakin)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
If I use a ext.manifest file with

content tests file:///tests/

I get a null COMPtr dereference at:

http://lxr.mozilla.org/mozilla/source/chrome/src/nsChromeProtocolHandler.cpp#599 as the file is null:

file->Exists(&exists);

Adding the drive letter works fine: file:///C|/tests/
(Assignee)

Comment 1

9 years ago
Created attachment 351176 [details] [diff] [review]
add nullcheck, this code is only called for debug anyway
Assignee: jag → enndeakin
Status: NEW → ASSIGNED
Attachment #351176 - Flags: review?(bsmedberg)

Updated

9 years ago
Attachment #351176 - Flags: review?(bsmedberg) → review?(benjamin)

Updated

9 years ago
Attachment #351176 - Flags: review?(benjamin) → review+
(Assignee)

Comment 2

9 years ago
Looks like this code when away yesterday anyway, so no longer needed ;)
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.