329620 - Fix strict JS warnings

Status: RESOLVED WORKSFORME

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

I get these:
1)
Warning: function _getSelectedValue does not always return a value
Source File: chrome://xforms/content/select1.xml
Line: 958, Column: 23
Source Code:
            return null;
2)
Warning: function _getSelectedValue does not always return a value
Source File: chrome://xforms/content/select1.xml
Line: 985, Column: 32
Source Code:
          return contentEnvelope;

Could probably be fixed via one of the select rewrites that surkov is doing.

Comment 1

[aaronr]

Alex, would you like to fix this with your select(1) rewrites or would you like me to fix this one?

Comment 2

[alexander :surkov (:asurkov)]

I understood the bug not very good. If I understand right then you can get the problem only at lines 904 and 906 of select1.xml (if _getSelectedValue() returns null or undefined). Is it a problem or something else? Is there problem for select control? 

I don't work on select1 control rewrites at the moment, thought I have nearest plans.

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> Alex, would you like to fix this with your select(1) rewrites or would you like
> me to fix this one?
> 

If the problem isn't concerned select control and since I didn't understance the bug a wholly then I would like you to fix it ;)

Comment 4

[aaronr]

I haven't looked at it yet, either, so I don't know exactly what the bug is, yet.  But I will look at it.  Probably something that I caused anyway when I was putting in my copy stuff.

Comment 5

[Allan Beaufour]

I've stopped getting these on trunk. They are fixed, right?