329659 - download manager open,remove and contextmenu don't work anymore

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060307 Firefox/1.6a1 ID:2006030710

repro:
1.download something
2.rightclick in download manager and choose anything
3.click on open or remove

result
nothing happens:

only the clean up button and doubleclick still work

Comment 1

[Peter van der Woude [:Peter6]]

regressionwindow:

works in 20060307 0857pst build
fails in 20060307 1047pst build

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-03-07+08%3A10&maxdate=2006-03-07+10%3A47&cvsroot=%2Fcvsroot

Comment 2

[:Gavin Sharp [email: [e-mail]]]

This is likely a regression from bug 234455, the DM fires events when the context menu options are selected.

http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/downloads/content/downloads.js#113

(should regressions from that bug block it, or depend on it? I wish bug 251556 was fixed on b.m.o :)

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

i'll test this later, but does
changing e.initEvent("download-" + aEventType, false, true);
to       e.initEvent("download-" + aEventType, true, true);
help here? Earlier events did always bubble in XUL, but not anymore.

Comment 4

[Tuukka Tolvanen (sp3000)]

> i'll test this later, but does
> changing e.initEvent("download-" + aEventType, false, true);
> to       e.initEvent("download-" + aEventType, true, true);
> help here? Earlier events did always bubble in XUL, but not anymore.

That change fixes the context menu, but not the Open/Remove links.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Comment 6

[Peter van der Woude [:Peter6]]

(In reply to comment #5)
> Created an attachment (id=214442) [edit]
> proposed patch
> 
mconnor is sick in bed acc. his blog

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 214442 [details] [diff] [review]
proposed patch

Thanks

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Checking in mozapps/downloads/content/download.xml;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/download.xml,v  <--  download.xml
new revision: 1.22; previous revision: 1.21
done
Checking in mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.55; previous revision: 1.54
done

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

While I don't have Win2000, I know for a fact this works on other Win32 platforms, such as XP and Vista.

Verified.