329726 - (maybe) ditch the stack-and-canvas based dimming on some platforms?

Status: RESOLVED INVALID

(Toolkit :: Safe Browsing, enhancement)

Description

[Fritz Schneider]

Right now the way we achieve dimming out the content area and showing the warning is rather kludgey. The main limitation is that you can't place semi-transparent areas over the browser content area -- it doesn't work, they just show up as grey. 

There are two implications for us. First, that we can't just overlay a semi-transparent png on the content area to dim it. Second, that the "tail" of the warning message would look weird if positioned over the content area (the image only fills part of the box; the rest would look grey). Hence, our abomination of a technique to get things to work out (see phishing-afterload-displayer.js and safebrowsing-overlay.xul).

However, I'm told that some recent changes might make this possible on some platforms (see depends on bug). Let's investigate whether we can't switch to something more sane (semi-transparent png to dim and transparent background on the tail) on the platforms that support it. 

At the very least, this can change in FFox 3.

Comment 1

[AndrewM]

Given that phishing protection has changed completely in Fx 3 (with an error page instead of the overlay bubble); should this now be marked INVALID?

Comment 2

[Tony Chang (Google)]

Yes, this seems obsolete by the content error message in ff3.