329750 - No confirmation dialog after clicking Clear History

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Ria Klaassen (not reading all bugmail)]

Steps to reproduce:
1. Menu History -> Clear History.
2. Everything in History disappears instantly, which is dangerous for I clicked it only by accident; meant to click View All History.

Comment 1

[Jo Hermans]

Confirmed on Firefox 2 branch (Mac OS). It's annoying because the menu item uses an ellipsis (Clear All History...), which indicates that a confirmation dialog is to be expected.

Comment 2

[Joe Hughes]

Attachment: Gets rid of "Clear History..." menu item, moves "Clear Private Data..." menu item from Tools menu to take its place

Comment 3

[Annie Sullivan]

Comment on attachment 216242 [details] [diff] [review]
Gets rid of "Clear History..." menu item, moves "Clear Private Data..." menu item from Tools menu to take its place

>-                <menuseparator id="startTabHistorySeparator"/>
>-                <menuseparator hidden="true" id="endTabHistorySeparator"/>
>-                <menuitem label="&historyClearCmd.label;"
>-                          command="Browser:ClearHistory"/>
>+                <menuseparator hidden="true" id="startTabHistorySeparator"/>
>+                <menuseparator id="sanitizeSeparator"/>
>+                <menuitem id="sanitizeItem" 
>+                          accesskey="&clearPrivateDataCmd.accesskey;"
>+                          label="&clearPrivateDataCmd.label;"
>+                          key="key_sanitize" command="Tools:Sanitize"/>

HistoryMenu.update() still references endTabHistorySeparator.  Please fix this, and make sure that the separators show correctly above and below the tab history when there is history, and only one separator shows when there is no tab history.

Comment 4

[Joe Hughes]

Attachment: update to address Annie's comment

Right, thanks.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 216270 [details] [diff] [review]
update to address Annie's comment

ui-review=me (beltzner's about a 1 in 4 chance to get to this soon)

note: brett filed a dupe for this late this week

Comment 6

[:Gavin Sharp [email: [e-mail]]]

*** Bug 331493 has been marked as a duplicate of this bug. ***

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 216270 [details] [diff] [review]
update to address Annie's comment

sr=[e-mail]

Comment 8

[Joe Hughes]

Landed on branch & trunk.

Comment 9

[Bryan]

Ughh!  I've always hidden the "Go" menu item (which has now become "History") via userChrome.css because it has never provided any value to me at all.  Now that "Clear Private Data" has been moved to "History" this is a pain.  Can we not get it back to Tools, since it performs the role of a tool?  Yes, I know I can "Ctrl+Shift+Del" to perform the same function.  I don't want to do that nor do I want to have "History" enabled just to be able to "Clear Private Data", it simply takes up valuable space on my menu bar and none of what I've seen as part of places provide any value to me in the "History" menu item.

Bryan

Comment 10

[Brett Wilson]

I don't think it will be moved back to tools. The point of the changes to the history menu are to make it useful (this goes beyond just "clear history". You're asking to make it useless so you can disable it, which is exactly opposite of the goal.

Comment 11

[Bryan]

Are there any hacks you're aware of that I can use in userChrome.css to "move" it back to tools?  As it stands now I have to keep that menu item enabled just to use that function (remember, I don't want to have to manually do it via keyboard cmds) and having it enabled throws off the icons i've added to the right of Help.  Arghhh

I would think you'd have to add alot more low hanging fruit in order to make the History menu item truly useful IMO.  

Bryan

Comment 12

[Brett Wilson]

(In reply to comment #11)
> Are there any hacks you're aware of that I can use in userChrome.css to "move"
> it back to tools?

Not CSS. You can write an extension.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Moving sanitizeItem into a MOZ_PLACES ifdef causes javascript errors starting the browser when places is not enabled (which we need at least for performance testing).

Comment 14

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv