329860 - small_close.tif no longer used and should be removed

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[davedit]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060205 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060205 Camino/1.0+

small_close.tif is still included in Camino's resources, but no longer appears to be used. It should probably be removed.

Reproducible: Always

Comment 1

[Samuel Sidler (old account; do not CC)]

Yep.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

See also bug 327795; please wack them both and cvs remove them.

Comment 3

[Samuel Sidler (old account; do not CC)]

Attachment: Remove small_close.tiff and filePreferences.icns from project file

This patch removes both small_close.tiff and filePreferences.icns from the project file. It was created against the trunk. I can make a branch version if needed.

Requesting review from Mark.

Comment 4

[Mark Mentovai]

Comment on attachment 216181 [details] [diff] [review]
Remove small_close.tiff and filePreferences.icns from project file

These objects are referenced all over the pbxproj.  You need to get rid of those references too, or you'll have a broken project file.  The easiest way to do this properly is to open it in Xcode, provided that 1.0 <= your xcode version <= 2.0.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Real Xcode-based changes

Something like this should make mento happier ;)  Files removed with Xcode 1.5.

Comment 6

[Samuel Sidler (old account; do not CC)]

That's funny. I had this exact patch which I was going to submit after testing it (the difference being I had edited the project file). In any case, it works.

r=me.

Comment 7

[Mark Mentovai]

Trunked and 1.8-branched, and cvs removed the dead files.