329892 - Places Toolbar doesn't redraw when adding or removing items

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Adam Kowalczyk]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060308 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060308 Firefox/1.5

I couldn't find exact steps to reproduce but it's very common. Often when adding a new folder or a separator they don't show up until a restart, although they get created, as can be seen in Places. Other times when removing an item it doesn't disappear. When trying to remove it again you get a failed assertion:

ASSERT: Node QI Failed.

Reproducible: Sometimes

Steps to Reproduce:
1. Play around Places Toolbar adding and removing folders and separators. 
2. If you can't hit the bug restart and try some more.

Comment 1

[Adam Kowalczyk]

OK, this is just messed up alright.

Try creating two folders with the same name in Places. Assertion. 

However you can create them on Places Toolbar. That is, sort of, because they don't show up on the Toolbar as described before and you can only see them in Places. An after all there seems to be only one folder actually because after deleting one of them you get an assertion when trying to delete the other. 

And so on.

Comment 2

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #0)
> Other times when removing an item it doesn't disappear.
> 
Bug 329804 ?

Comment 3

[Adam Kowalczyk]

(In reply to comment #0)
> Bug 329804 ?

Only in part. I think it probably involves a couple of things but it's all so broken that it's hard to isolate them as separate bugs:
1) Places Toolbar and Places Manager not redrawn
2) PT and PM redrawn incorrectly by showing multiple folders with the same name when there's only one
3) inability to create multiple folders with the same name which leads to
- assertion when attempting to do that from PM
- fake entries when from PT
4) all the above leading to assertions when deleting non-existent items

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Annie, I've seen this a few times can you take a look? 

Comment 5

[Annie Sullivan]

Attachment: Fixes parent check on some observer notifications

I've only seen this problem when adding/removing folders, and when I looked at the code, I saw that there is indeed a bug with this part.  Not sure if this will fix all the problems with updating.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 214610 [details] [diff] [review]
Fixes parent check on some observer notifications

r=[e-mail]

Comment 7

[Adam Kowalczyk]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060309 Firefox/1.5 ID:2006031002

This patch only dealt with folders. There are still problems with separators. Repro:
1. Add a separator to Places Toolbar.
2. Add a folder.
3. Add another separator.
4. Remove the first separator.

Results: the separator is still displayed, only it gets moved to the end of the PT folder.

Also, the tree in the Places window isn't updated when creating and removing folders but I'm not sure it's within the scope of this bug. Should I file it separately?

Comment 8

[Annie Sullivan]

Attachment: Fixes problem where notifications when re-ordering items after delete confused separator code

Comment 9

[Annie Sullivan]

> Also, the tree in the Places window isn't updated when creating and removing
> folders but I'm not sure it's within the scope of this bug. Should I file it
> separately?

I don't see the problem with the tree not getting updated when creating and removing folders.  It's a separate bug; can you file one and assign it to me with steps to reproduce?

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv