330043 - Add param with an independant versioning scheme

Status: RESOLVED INCOMPLETE

(Toolkit :: Safe Browsing, defect)

Description

[Robert Accettura [:raccettura]]

Looking over the Design Documentation one param "client" is of slight concern to me.  If/when Safe Browsing ships with Firefox it should contain an independant version number.

Reason being is so that if there is a need/reason for an API change, we can do so more gracefully, without having several url's for different versions that we need to support (which IMHO is a pain).

I see two practical solutions:

1.  Sent a client of "SafeBrowsing-1.0" or something to that effect.
2.  If there is a desire to know the client (Firefox, vs. a downstream vendor's app) set client to the product Name (i.e. Firefox) and create a new param "vers" which refers to the version of the Safe Browsing extension.

IMHO #2 is more desirable.

The version number should be of the version of safe browsing shipping, not product version (since downstream vendors may use a different versioning scheme).

It's possible the version param may never truly be used.  But IMHO it adds a little more flexibility by letting the server know exactly what version of the client it's dealing with.

Comment 1

[Tanner M [:Tannn3r]]

Reporter, can you still reproduce this bug in Firefox 10.0.2?

Please update to Firefox 10.0.2 or later, update your plugins, and retest in a new profile. If you still see the issue with the updated version of Firefox, please post here. Otherwise, please close as RESOLVED > WORKSFORME.

http://getfirefox.com/
http://support.mozilla.com/kb/Managing+profiles

Comment 2

[Phoenix]

Resolved per whiteboard