The default bug view has changed. See this FAQ.

Phishing State should take precedence over Junk State in the message bar

RESOLVED FIXED in seamonkey1.1alpha

Status

SeaMonkey
MailNews: Message Display
--
major
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

(4 keywords)

unspecified
seamonkey1.1alpha
fixed-seamonkey1.0.1, fixed-seamonkey1.1a, fixed1.8.0.2, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
This is the mailnews version of TB bug 298525. Precedence order should be Phish, Junk and then remote content.
(Assignee)

Comment 1

11 years ago
Created attachment 214779 [details] [diff] [review]
Simple patch v0.1 (Checked in trunk & branch 1.8 / 1.8.0)

This patch:
* Swaps order of deck, and related JS, so that phishing takes precedence over junk bar
* Updates comment to reflect new order
* Removes unused variable isCurrentlyNotJunk
Assignee: mail → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #214779 - Flags: review?(neil)

Updated

11 years ago
Attachment #214779 - Flags: review?(neil) → review+
(Assignee)

Updated

11 years ago
Attachment #214779 - Flags: superreview?(bienvenu)

Updated

11 years ago
Attachment #214779 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Comment 2

11 years ago
Comment on attachment 214779 [details] [diff] [review]
Simple patch v0.1 (Checked in trunk & branch 1.8 / 1.8.0)

Checking in (trunk)
mailWindowOverlay.js;
new revision: 1.230; previous revision: 1.229
mailWindowOverlay.xul;
new revision: 1.307; previous revision: 1.306
done
Attachment #214779 - Attachment description: Simple patch v0.1 → Simple patch v0.1 (Checked in trunk)
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

11 years ago
Comment on attachment 214779 [details] [diff] [review]
Simple patch v0.1 (Checked in trunk & branch 1.8 / 1.8.0)

Rqeuesting a= for SM1.0.1 and SM1.1a
Attachment #214779 - Flags: approval-seamonkey1.1a?
Attachment #214779 - Flags: approval-seamonkey1.0.1?

Comment 4

11 years ago
Comment on attachment 214779 [details] [diff] [review]
Simple patch v0.1 (Checked in trunk & branch 1.8 / 1.8.0)

low-risk security-relevant fix, should be consistent in all new releases, a=me for both 1.1 and 1.0.1
Attachment #214779 - Flags: approval-seamonkey1.1a?
Attachment #214779 - Flags: approval-seamonkey1.1a+
Attachment #214779 - Flags: approval-seamonkey1.0.1?
Attachment #214779 - Flags: approval-seamonkey1.0.1+
(Assignee)

Comment 5

11 years ago
Comment on attachment 214779 [details] [diff] [review]
Simple patch v0.1 (Checked in trunk & branch 1.8 / 1.8.0)

Checking in (branch 1.8)
mailWindowOverlay.js;
new revision: 1.222.2.7; previous revision: 1.222.2.6
mailWindowOverlay.xul;
new revision: 1.298.2.8; previous revision: 1.298.2.7
done
Attachment #214779 - Attachment description: Simple patch v0.1 (Checked in trunk) → Simple patch v0.1 (Checked in trunk & branch 1.8)
(Assignee)

Updated

11 years ago
Keywords: fixed-seamonkey1.1a
(Assignee)

Comment 6

11 years ago
Comment on attachment 214779 [details] [diff] [review]
Simple patch v0.1 (Checked in trunk & branch 1.8 / 1.8.0)

Requesting a= for 1.8.0.2 as suggested by dveditz
Attachment #214779 - Flags: approval1.8.0.2?
Comment on attachment 214779 [details] [diff] [review]
Simple patch v0.1 (Checked in trunk & branch 1.8 / 1.8.0)

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #214779 - Flags: approval1.8.0.2? → approval1.8.0.2+
(Assignee)

Comment 8

11 years ago
Comment on attachment 214779 [details] [diff] [review]
Simple patch v0.1 (Checked in trunk & branch 1.8 / 1.8.0)

Checking in (branch 1.8.0)
mailWindowOverlay.js;
new revision: 1.222.2.3.4.4; previous revision: 1.222.2.3.4.3
mailWindowOverlay.xul;
new revision: 1.298.2.2.4.7; previous revision: 1.298.2.2.4.6
done
Attachment #214779 - Attachment description: Simple patch v0.1 (Checked in trunk & branch 1.8) → Simple patch v0.1 (Checked in trunk & branch 1.8 / 1.8.0)
(Assignee)

Updated

11 years ago
Keywords: fixed-seamonkey1.0.1

Comment 9

11 years ago
This was seamonkey only, but we had to approve the patch to land on the 1.8.0 branch.  It landed on 3/17/06, but not marked fixed1.8.0.2 as it is seamonkey only.  It still shows up on the NeedsLanding list because it is approved for 1.8.0.2 but not marked fixed1.8.0.2.  Should we mark it fixed1.8.0.2 or take off the approval flag?
Keywords: fixed1.8.0.2

Updated

11 years ago
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.