330227 - ASSERT: Node QI Failed When deleting item from Bookmarks Toolbar

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Ryan Jones-Ward [:sciguyryan]]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20060311 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20060311 Firefox/1.5

ASSERT: Node QI Failed
Stack Trace:
0:QI_node(null,nslNavHistoryFolderResultNode)
1:asFolder(null)
2)PC__removeRange([xpconnect wrapped (nslSupports, nslNavHistoryResultNode, nslNavHistoryFolderResultNode)],)
3:PC__removeRowsFromBookmarks(Remove Selection)
4:PC_remove(Remove Selection)
5:oncommand([object MouseEvent])

May be mistakes because I typed it by hand.

Ths occured when I went into Bookmarks->Organise Bookmarks->Bookmaks Toolbar and then tried to remove an item from the list (On the left) via right cick and delete. This does not occur when its done from the select menu on the right hand side.

Reproducible: Sometimes

Steps to Reproduce:
1.See above.
2.
3.

Actual Results:  
See above.

Expected Results:  
Error message and no result

Should have removed the bookmark (SS feed in this case)?

Comment 1

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060311 Firefox/1.6a1
I see the same. Deleting the first folder is no problem, but the second one throws the error. Also when there are no spaces in the folder.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Get also crashes: TB16269429K  TB16269658X TB16269353Q

Comment 3

[timeless]

i'm not sure these stacks relate...

Incident ID: 16269429
Stack Signature	0x67657461 3fb28a7f
Product ID	FirefoxTrunk
Build ID	2006031205
Trigger Time	2006-03-12 08:42:23.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	
URL visited	
User Comments	Deleting folders
Since Last Crash	100 sec
Total Uptime	241 sec
Trigger Reason	Access violation
Source File, Line No.	N/A
Stack Trace 	
0x67657461
get_interesting_appn  [c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/jpeg/jdmarker.c, line 708]
nsBlender::GetAlphas  [c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/gfx/src/nsBlender.cpp, line 374]
nsRegion::InsertAfter  [c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/gfx/src/nsRegion.cpp, line 249]

Incident ID: 16269658
Stack Signature	0x00f502ab b0e4c06f
Product ID	FirefoxTrunk
Build ID	2006031205
Trigger Time	2006-03-12 08:49:11.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	
URL visited	
User Comments	
Since Last Crash	72 sec
Total Uptime	313 sec
Trigger Reason	Access violation
Source File, Line No.	N/A
Stack Trace 	
0x00f502ab
nsScriptableRegion::IntersectRegion  [c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/gfx/src/nsScriptableRegion.cpp, line 80]
sqlite3pager_open  [c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/db/sqlite3/src/pager.c, line 1657]
sqlite3DeleteFrom  [c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/db/sqlite3/src/delete.c, line 314]
0x020e7fa0
0x011847c7

Incident ID: 16269353
Stack Signature	_NULL_IMPORT_DESCRIPTOR 5a08dcf2
Product ID	FirefoxTrunk
Build ID	2006031205
Trigger Time	2006-03-12 08:39:52.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	xpcom_core.dll + (000495c8)
URL visited	
User Comments	Deleting folders in Places
Since Last Crash	141 sec
Total Uptime	141 sec
Trigger Reason	Privileged instruction
Source File, Line No.	N/A
Stack Trace 	
_NULL_IMPORT_DESCRIPTOR
nsScriptableRegion::IntersectRegion  [c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/gfx/src/nsScriptableRegion.cpp, line 80]

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

I believe this, and all the crashes reported, have been fixed by 323812. 

Comment 5

[Ryan VanderMeulen [:RyanVM]]

*** Bug 332071 has been marked as a duplicate of this bug. ***

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv