editline.c:1038: warning: implicit declaration of function `getpid'

RESOLVED FIXED in mozilla1.9.1b1

Status

()

Core
JavaScript Engine
--
trivial
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
mozilla1.9.1b1
PowerPC
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

12 years ago
editline.c: In function `readline':
editline.c:1038: warning: implicit declaration of function `getpid'
(Assignee)

Comment 1

12 years ago
Created attachment 214829 [details] [diff] [review]
it's available in unistd.h and sys/types.h on osx ...
Attachment #214829 - Flags: review?(shaver)

Updated

12 years ago
Flags: in-testsuite-
Comment on attachment 214829 [details] [diff] [review]
it's available in unistd.h and sys/types.h on osx ...

r=shaver
Attachment #214829 - Flags: review?(shaver) → review+
(Assignee)

Comment 3

12 years ago
Comment on attachment 214829 [details] [diff] [review]
it's available in unistd.h and sys/types.h on osx ...

mozilla/js/src/editline/editline.c 	1.7
Attachment #214829 - Attachment is obsolete: true
(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 4

12 years ago
This breaks building editline.c on macosx 10.4 

editline.c:158: error conflicting types for 'read'
/usr/include/unistd.h:441: error: previous declaration of 'read'
editline.c:159: error conflicting types for 'write'
/usr/include/unistd.h:477: error previous declaration of 'write'

please fix or back out asap as it blocks building jsshell on macosx.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 5

12 years ago
Created attachment 227531 [details] [diff] [review]
revert

back it out so i can get on with testing.
Attachment #227531 - Flags: review?(shaver)
Comment on attachment 227531 [details] [diff] [review]
revert

r=shaver, sorry for r+ing the previous badness.
Attachment #227531 - Flags: review?(shaver) → review+

Comment 7

12 years ago
from attachment 227531 [details] [diff] [review]
Checking in editline.c;
/cvsroot/mozilla/js/src/editline/editline.c,v  <--  editline.c
new revision: 1.8; previous revision: 1.7
(Assignee)

Comment 8

12 years ago
Created attachment 227877 [details] [diff] [review]
remove obsolete support

sorry bob. some of us are busy getting fired here.
Attachment #227531 - Attachment is obsolete: true
Attachment #227877 - Flags: review?(mrbkap)

Comment 9

12 years ago
Created attachment 227885 [details]
build log for js shell opt on osxmac

builds fine for me on mac with this patch.

Updated

12 years ago
Attachment #227877 - Flags: review?(mrbkap) → review+

Updated

10 years ago
Keywords: checkin-needed

Comment 10

10 years ago
Patch still works, checkin-needed
http://hg.mozilla.org/mozilla-central/rev/48ca5b355829
Status: REOPENED → RESOLVED
Last Resolved: 12 years ago10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
You need to log in before you can comment on or make changes to this bug.