330269 - RTL text typed at end of line is reversed

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Uri Bernstein]

This is a regression from bug 319930, which is much easier to fix that to describe. I'll do my best anyway:
In an LTR textarea, type LTR text into the first line, leaving space for a few characters at the end of the line.
Now type space, and *exactly* the number of RTL characters necessary to fill up the line.
Now type anothe space, and more RTL characters. These characters will appear on the next line, but in the wrong direction (i.e., LTR).

This is because in my patch for bug 319930 I neglected to reset the embeddingLevel, baseLevel, and charType attributes on the continuation frames that I'm freeing up for use by the inline reflow code.

Patch will follow soon.

Comment 1

[Uri Bernstein]

Attachment: patch

Set the attributes of the freed-up in-flows to be equal to those of the frame they're continuing.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 214842 [details] [diff] [review]
patch

sr=bzbarsky if those properties are guaranteed to be set on aFrame (something we should assert, perhaps?)

Comment 3

[Uri Bernstein]

Attachment: patch with asserts

Yes, I believe the properties should always be set on aFrame, so added ASSERTs to assert this.

Comment 4

[Uri Bernstein]

Checked in:
Checking in layout/base/nsBidiPresUtils.cpp;
/cvsroot/mozilla/layout/base/nsBidiPresUtils.cpp,v  <--  nsBidiPresUtils.cpp
new revision: 1.69; previous revision: 1.68
done

Comment 5

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).