330274 - Tell addSearchEngine we're using https to avoid the redirects

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Phil Ringnalda (:philor)]

Adding a search engine calls

     window.sidebar.addSearchEngine(
       "http://addons.mozilla.org/search-engines-static/"+name+".src",
       "http://addons.mozilla.org/search-engines-static/"+name+"."+ext, name, cat );

which then requires two redirects to https...

Comment 1

[Mike Shaver (:shaver emeritus)]

morgamic: we fixed this when the redirects were broken, right?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

It was checked in, but not pushed to production, as I understand it.
http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=2006-04-26+20%3A11&maxdate=2006-04-26+20%3A11&cvsroot=%2Fcvsroot
https://addons.mozilla.org/js/search-plugin.js

Comment 3

[Phil Ringnalda (:philor)]

And was then pushed, and caused bug 335602 because things < 1.5.0.4 are broken for https. wontfix? It doesn't seem like a big enough deal to bother having separate schemes in the addSearchEngine call based on the browser version.

Comment 4

[Michael Morgan [:morgamic]]

This has to use http to avoid complications with < 1.5.0.4.  The fix was put in earlier in April but was rolled back because of complaints.  The redirects will stay for a while until the majority of our user base is using a version that doesn't barf on https search-plugin URIs.