Closed
Bug 330284
Opened 19 years ago
Closed 19 years ago
Missing parentheses in patch for bug 303884
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: uriber, Assigned: uriber)
References
Details
Attachments
(1 file)
|
2.04 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
In the patch for bug 303844, I made the wrong assumption that "&" has higher precedence than "==". This is wrong, as I would have found out had I looked it up instead of assuming. Hence, parentheses have to be added in two places.
Patch coming right up.
|
Assignee | |
Comment 1•19 years ago
|
||
Assignee: mozilla → uriber
Status: NEW → ASSIGNED
Attachment #214857 -
Flags: superreview?(roc)
Attachment #214857 -
Flags: review?(smontagu)
Attachment #214857 -
Flags: superreview?(roc)
Attachment #214857 -
Flags: superreview+
Attachment #214857 -
Flags: review?(smontagu)
Attachment #214857 -
Flags: review+
|
|
Assignee | |
Comment 2•19 years ago
|
||
Thanks, roc!
Checked in:
Checking in layout/generic/nsFrameList.cpp;
/cvsroot/mozilla/layout/generic/nsFrameList.cpp,v <-- nsFrameList.cpp
new revision: 3.35; previous revision: 3.34
done
|
|
Assignee | |
Comment 3•19 years ago
|
||
Hmmm... I'm sure I *meant* to resolve this FIXED when submitting the previous comment.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
|
||
Updated•19 years ago
|
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: zach → layout.fonts-and-text
You need to log in
before you can comment on or make changes to this bug.
Description
•