330637 - Places Organizer asserts after moving folder

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P2)

Description

[Pam Greene]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20060315 Firefox/1.5

The Places Organizer displays a corrupted list of bookmarks and can be made to throw an assertion after moving a folder of bookmarks into the Bookmarks Toolbar folder.

Seen on both Mac and Linux.

Reproducible: Always

Steps to Reproduce:
1. Launch with a new profile
2. Organize Bookmarks (see screenshot #1)
3. Drag "Firefox and Mozilla Links" into Bookmarks Toolbar folder above it
4. Expand Bookmarks Toolbar folder (see screenshot #2): notice two copies of "Firefox and Mozilla Links"
5. Attempt to delete bottom copy of that folder (see screenshot #3)
Actual Results:  
Places list is out of order, moved folder is duplicated, and program gives an assertion. See screenshots.

Expected Results:  
Moved folder is placed in destination and not still shown in its original location. Destination folder opens properly, not showing half its contents above itself. Nonexistent folder cannot be deleted.

Seen on both

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20060315 Firefox/1.5

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060315 Firefox/1.5

Comment 1

[Pam Greene]

Attachment: Places Organizer

Comment 2

[Pam Greene]

Attachment: Confused Places list after moving folder

Comment 3

[Pam Greene]

Attachment: Assert dialog after deleting duplicate folder

Comment 4

[Ria Klaassen (not reading all bugmail)]

The weirdness with "Firefox and Mozilla Links" is, that it only seems to live in the Places View. I can't find it elsewhere in menus or toolbar which are the only two possibilities.
And nearly every action on the left hand panel leads to strange behaviour followed by errors indeed.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

I think this works now.

Comment 6

[Pam Greene]

Still broken for me, with the March 28 nightlies.  Same behavior as originally described on Mac.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20060328 Firefox/2.0a1

On Linux, the second copy of "Firefox and Mozilla Links" isn't shown at the bottom of the left list after it's been moved into "Bookmarks Toolbar", but a blank line below the named items in the list can be selected.  It shows on the right an apparently arbitrary list of bookmarks in the nonexistent folder -- often, but not always, the list that was shown for whatever left item had last been clicked.

To see that:

Steps 1-4 as above
5. Select empty row below "Subscriptions" in left list.  See that it can be selected, and that items show in the right pane.
6. Select another item in the left, then the empty row again.  Items in the right pane change.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060328 Firefox/2.0a1

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

This sounds like a view updating problem now (the assert was in the fe remove code)

Comment 8

[Brett Wilson]

If I drag a folder from the left view to the bottom of the left view, I get an invalid index assertion. I think it's doing -2 again.

I'm marking this as being blocked by the index bug. I think having indices will improve the frontend code in many respects.

Comment 9

[Dietrich Ayala (:dietrich)]

wfm in current nightly.

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv