Closed Bug 330726 Opened 19 years ago Closed 15 years ago

Mozilla crash when contents of chrome directory has deleted.

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: romaxa, Unassigned)

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (X11; U; Linux i686; ru-RU; rv:1.7.12) Gecko/20050922 Firefox/1.0.7 (Debian package 1.0.7-1) Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ru-RU; rv:1.7.12) Gecko/20050922 Firefox/1.0.7 (Debian package 1.0.7-1) Engine chrash in layout and appshell module, when chrome directory is empty. It is related for building embedded mozilla with --disable-xul option, https://bugzilla.mozilla.org/show_bug.cgi?id=319346 Reproducible: Always Steps to Reproduce: 1. Build mozilla TestGtkEmbed and install it 2. Remove all contents of "chrome" directory 3.Run TestGtkEmbed Actual Results: Application should start, even without scrollbars, or notify about problems (In Firefox for example...) Expected Results: Firefox or mozilla-suite not started.. TestGtkEmbed - is crashed
Tere are two checks for undefined value in laoyout/generic/nsFrame.cpp and nsAbout.cpp in xfpe/appshell
I assume you're testing with trunk source from CVS, and you're just using Firefox 1.0.7 to write this? Otherwise, can you reproduce this with the latest source?
Attachment #215311 - Flags: superreview?(bzbarsky)
Attachment #215311 - Flags: review?(neil)
Comment on attachment 215311 [details] [diff] [review] BUGFIX: removes crashing of mozilla when chrome components has not found. Looks vaguely reasonable.
Attachment #215311 - Flags: review?(neil) → review+
(In reply to comment #2) > I assume you're testing with trunk source from CVS, and you're just using > Firefox 1.0.7 to write this? Otherwise, can you reproduce this with the latest > source? > Mozilla sources has been checkouted from trunk, but /embedding/browser/gtk directory from 2006-01-26 (Because current updates has some problems.. :( ) Has been checked on Firefox Release 1.5.0.1, it also crashed.
(In reply to comment #3) > (From update of attachment 215311 [details] [diff] [review] [edit]) > Looks vaguely reasonable. > As I understand patch has been applied to trunk? This bug can be closed already?
um. it has a review. there's a superreview pending someone who's on vacation. if you're in a hurry we can find someone else to do that. it shouldn't be on trunk until after it gets its reviews and superreviews. and to actually get into cvs you have to remind/ask someone to commit it.
Attachment #215311 - Flags: superreview?(dveditz)
Attachment #215311 - Flags: superreview?(bzbarsky)
Attachment #215311 - Flags: approval-branch-1.8.1?(dveditz)
dan, can you sr+ and approve for the branch?
Assignee: nobody → dougt
Status: UNCONFIRMED → NEW
Ever confirmed: true
david, can you also look at this patch?
Comment on attachment 215311 [details] [diff] [review] BUGFIX: removes crashing of mozilla when chrome components has not found. For future reference, please have more context and use the -p option. Something like -pu8 is a good set of diff options. The second hunk of this patch is wrong, imo. BoxMetrics() shouldn't be returning null. If it is, then something is deeply wrong (as the corresponding assert in BoxMetrics() indicates). If we're running into a case when someone is screwing up that badly we should find whoever that is and fix them instead of adding this random wallpaper.
Attachment #215311 - Flags: superreview?(dveditz)
Attachment #215311 - Flags: superreview-
Attachment #215311 - Flags: approval-branch-1.8.1?(dveditz)
Attachment #215311 - Flags: approval-branch-1.8.1-
mass reassigning to nobody.
Assignee: dougt → nobody
I think this bug is not important anymore.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: