330745 - odbc libraries on some link lines break VC8 Express builds

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

VC8 Express doesn't include the ODBC libraries.  I think the fact that various Makefile.in's try to link with them is a bug, since removing them from the link lines doesn't break anything.  Patch forthcoming...

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: remove odbc libs from links lines, v1

This patch is for the current client branch.  I suspect it also wants to land on the upcoming new client branch as well as the trunk.

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> I suspect it also wants to land on the upcoming new client branch as
> 

That would be a very good idea ;-)

Comment 3

[Rich Megginson]

I removed them from the trunk LDAP C SDK builds, the v5.17 tags

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

The 5.17 tags move without changing version number?  If so, won't the new client branch have the issue that we won't know which "5.17" it was cut from without going back and looking at the various individual file revisions?

Comment 5

[Rich Megginson]

No, the v5.17 tags do not move.  Part of the changes I did for the code tagged as LDAPCSDK_5_1_7_RTM was to remove the dependency on the odbc libraries.  So if the client uses LDAPCSDK_5_1_7_RTM as the branch point they are guaranteed to have a stable branch point.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Ah, I get it.  So in fact, the new client branch should already have this fix.  No need to landed this patch, then; we'll just wait for the upgrade (tomorrow!)

Comment 7

[Mark Banner (:standard8)]

Now that we've upgraded to the latest c-sdk on trunk, I guess this bug is fixed as well :-)

- patch on bug 325625.