330803 - User facing errors shouldn't talk about integers and should be consistent

Status: RESOLVED WONTFIX

(Bugzilla :: Bugzilla-General, defect)

Description

[timeless]

[% ELSIF error == "votes_must_be_nonnegative" %]
    [% title = "Votes Must Be Non-negative" %]
    [% admindocslinks = {'voting.html' => 'Setting up the voting feature'} %]
    Only use non-negative numbers for your [% terms.bug %] votes.
...
  [% ELSIF error == "illegal_user_id" %]
    [% title = "Illegal User ID" %]
    User ID '[% userid FILTER html %]' is not valid integer.

expected results:
don't talk to end users about integers, especially "valid" ones. If you mean non-negative, then it seems that's ok w/ some other part of the error file ...

Comment 1

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v1

Just mentioning "valid" is enough,IMO.

Comment 2

[Frédéric Buclin]

Comment on attachment 778961 [details] [diff] [review]
Patch-v1

>     [% title = "Illegal User ID" %]
>-    User ID '[% userid FILTER html %]' is not valid integer.
>+    User ID '[% userid FILTER html %]' is not valid.

"is not valid" is too vague as it could also mean "there is no user with such an ID" or "you are not allowed to view this account" even in the case of a valid integer. This error is thrown only when an admin didn't pass an integer, so the error message is accurate as is really about integers, nothing else. I see no reasons to reword it.

My vote to WONTFIX this bug.

Comment 3

[Frédéric Buclin]

(In reply to timeless from comment #0)
> don't talk to end users about integers

This message is only displayed to admins, not end users. So WONTFIX per my previous comment.