330843 - product_disabled says Bugs Entry, it probably should say Bug Entry

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[timeless]

[% ELSIF error == "product_disabled" %]
    [% title = BLOCK %]Product closed for [% terms.Bugs %] Entry[% END %]
    [% admindocslinks = {'products.html' => 'Administering products'} %]
    Sorry, entering [% terms.bugs %] into the
    product <em>[% product FILTER html %]</em> has been disabled.

Comment 1

[Mike Durthaler]

Attachment: Corrected plural use of bugs where singular use was needed.

Saved the old code just above the implementation of the edit I made to the product_disabled template.

Comment 2

[Tim Henigan]

Mike,

I considered taking this bug, but saw that you had already submitted work.  Its good to see other people interested in helping with the Bugzlla project.

I have a few comments regarding your submission that should help get this change approved and committed in the repository:

1) You should only submit a patch of your fix, not the entire file.  There have already been many changes to the file since you posted this change.  Submitting a patch insures that your work remains valid longer after the fix is submitted.  As things stand, this file will have to be rejected because of unrelated changes that have been made by other developers.  See http://wiki.mozilla.org/Bugzilla:Patches

2) You must request a review of the patch once it is submitted.  See http://wiki.mozilla.org/Bugzilla:Review

3) Your patch should not include personal comments or notes unless there are intended to be part of the production code.  Also, unused code should be removed from the file rather than commented out.

4) I believe that only one line of code needed to be modified.  Specifically, the line that states "Product closed for [% terms.Bug %] Entry".  The second line that you modified "Sorry, entering [% terms.Bugs %] into the" should remain plural.

Sorry for the lengthy comment.  I hope my comments were helpful.

Thanks,
Tim

Comment 3

[Rupert Handford]

This appears to be correct in the current CVS version.

Comment 4

[Dave Miller [:justdave]]

This was fixed by attachment 320765 [details] [diff] [review] on bug 330989