330989 - illegal_change_deps error uses "empowered" inconsistently with "allowed"

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[timeless]

[% ELSIF error == "illegal_change_deps" %]
    [% title = "Not allowed" %]
    You tried to change the
    <strong>[% field_descs.$field FILTER html %]</strong> field
    but only a user empowered to edit
    both involved [% terms.bugs %] may change that field.

Comment 1

[timeless]

perhaps "empowered" is a word we want to use.

illegal_change uses it too. but i personally don't like it.

Comment 2

[Max Kanat-Alexander]

Yes, I much prefer "allowed."

Comment 3

[Mike Durthaler]

Changed "empowered" to "allowed" and took the liberty to also change "involved" to "related" as it makes more sense.  "Involved" is correct enough in strict sense but "related" much better refers to issues such as fixing matters. "Involved" carries a "culpable" connotation -- "related" means that one issue has relation to another -- a much better choice of words.

I see "illegal_change" is mentioned above and as well another change is needed at "flag_update_denied".  I changed these to read " [Only] a user assinged the required permissions may ..." from the way the context read in both of these areas.

"sufficiently empowered" is correct but the more common (and thus more rapidly grasped) usage is "Only a user assinged the required permissions may ..." etc.

Mike

Mike

Comment 4

[Mike Durthaler]

Attachment: Yet again this file changes ... make sure to get the most recent stamp.

I think this is the last user-error file edit that's in the bug list. 

Sorry for the many resends :)

Mike

Comment 5

[Mike Durthaler]

I got with my local LAMP buddy here in Cincinnati who helped me get set up with GNU Diff. Here's the patch file that covers any template file edits up to this point.

Mike

Comment 6

[Mike Durthaler]

Attachment: Handles any template edits from beginning of bug list up to and including 330989

I'm a bit new at this -- here's my first patch file.

If other info is needed on this let me know.

Mike

Comment 7

[Frédéric Buclin]

Comment on attachment 314111 [details] [diff] [review]
Handles any template edits from beginning of bug list up to and including 330989

>-    Only a sufficiently empowered user can make this change.
>+    Only a user assinged the required permissions may make this change.

assinged?? Why not "... a user with the required permissions..."?


>-    a sufficiently empowered user may change that field.
>+    a user assinged the required permissions may change that field.

Same comment here.


>-    but only a user empowered to edit 
>-    both involved [% terms.bugs %] may change that field.
>+    but only a user allowed to edit 
>+    both related [% terms.bugs %] may change that field.

Personally, I prefer "involved" (but I'm not a native english-speaker).


>     [% title = "Milestone Required" %]
>-    You must determine a target milestone for [% terms.bug %] 
>+    You must select a target milestone for [% terms.bug %] 

Is this change really related to this bug??


>-  [% ELSIF error == "product_disabled" %]
>+#   MD 6 Apr 08: I save old code when submitting a change.  
>+[%#  [% ELSIF error == "product_disabled" %]

Don't add such pseudo-comments in a patch. Moreover, this is unrelated to this bug.


Next time you attach a patch, don't forget to request review by setting the flag to "review?", else nobody will notice your patch.

Comment 8

[Mike Durthaler]

I changed "determine" to "select" as it's the word to use when a person is choosing amongst several given items.  If he's figuring out something from no given items, then "determine" is more appropriate. I can change it back if you like but I took liberty here to correct usage throughout the document to be consistent.

I removed the psuedo comments and made the changes you suggested, that is "assigned" to "with". I'm a native english speaker and I have to agree with you. :)

Mike

Comment 9

[Mike Durthaler]

Attachment: user-error.html.tmpl new patch

Comment 10

[timeless]

Comment on attachment 314144 [details] [diff] [review]
user-error.html.tmpl new patch

@@ -1206,19 +1206,19 @@
-    Sorry, entering [% terms.bugs %] into the
+    Sorry, entering [% terms.bug %] into the

this should be terms.abug

Comment 11

[Frédéric Buclin]

Attachment: user-error.html.tmpl new patch, v2

Fixing timeless's comment. Credits still go to Mike, of course.

Comment 12

[Frédéric Buclin]

I will let mkanat decide if he wants it for 3.2 or for 4.0 only.

Comment 13

[Max Kanat-Alexander]

Having things like this go on as few branches as possible is really nice. These broad, tiny template changes make life hard for both customizers and localizers--they take a lot of work to merge or update, without being important enough to justify the work.

Comment 14

[Frédéric Buclin]

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.249; previous revision: 1.248
done