331066 - View source window does not tile properly or remember size/position

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The new view-source in window (yay!) has a few issues with tiling behavior:

I have my windows full-height.  When I open a new browser window, the new window is full-height, and, because it can't stagger downward and remain full-height, the new window just staggers to the right (as does each successive window).  This is the way tiling is supposed to work in this case.

The source window, however, does not behave the same way.  It 1) shrinks the height and 2) tiles too far down (instead of the standard titlebar+2px height, this is like titlebar-and-a-half).  Also, if I open a second source window while the first is open (say, to compare the sources of two pages), the second window opens exactly on top of the first instead of tiling at all!

Moreover, the source window always opens at the same size and position; it doesn't remember it's been resized.

Comment 1

[Chris Lawson (gone)]

But if the view-source window is the last window closed, Camino *does* remember its placement/sizing and makes the next full browser window in that location. Ew.

cl

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Chris mentioned on irc the other day he had some ideas about what was causing some of this.

I noticed the other day that the size/position of the source window are exactly what a full-height window with collapsed toolbar would be if said window were "stuck" to the bottom of the screen rather than being "stuck" to the menubar....

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Chris, any more ideas about fixing these?  It gets pretty ugly on reopening when you've opened a source window at one point in your previous session ;)

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

...but I really wish cl would fix this :P

Comment 5

[Chris Lawson (gone)]

Attachment: prevents remembering of size/position for view-source windows

This prevents view-source window sizes/positions from being saved, which fixes the most annoying of the multiple problems discussed here -- that having a view-source window totally screws up browser window positioning if the view-source window was the last thing closed.

The other issues are going to be spun off into separate bugs, says Smokey.

Comment 6

[Chris Lawson (gone)]

By the way, the fact that this bug and related issues exist at all is another very strong argument in favour of rolling a custom window class for view-source windows, so we can remember their sizes and positions separately from browser windows and not have to deal with ugly things like hiding toolbars to make them seem like they're something they aren't.

Comment 7

[froodian (Ian Leue)]

Comment on attachment 262594 [details] [diff] [review]
prevents remembering of size/position for view-source windows

r=me, but make sure we do file followups about the other issues mentioned in the bug.

Also, as a reminder to whomever checks this in, please change "prettyness" to "prettiness" in the comment one line above this diff.

Comment 8

[Stuart Morgan]

Comment on attachment 262594 [details] [diff] [review]
prevents remembering of size/position for view-source windows

>+    [controller disableAutosave]; // don't save view-source window size/position

Move this up to immediately after the
  [controller setChromeMask:kNoToolbarsChromeMask];
and sr=smorgan.

Comment 9

[froodian (Ian Leue)]

Checked in with smorgan's comment on trunk and MOZILLA_1_8_BRANCH.  Bug 378841 is the followup.