331183 - locale compariotr error doesn't explain what to change to make the build error go away

Status: RESOLVED INCOMPLETE

(Firefox Build System :: General, defect)

Description

[timeless]

Steps:
1. add a new string to chrome content and the en-US locale
2. commit with reviews

Actual Results:
Build Log (Brief)
Linux prometheus Depend release on 03/21 02:01:00
Show Full Log
Return to the Build Page
Add a Comment to the Log 1142935260, Linux prometheus Depend release
Build Error Summary

gmake[8]: *** [libs] Error 1
gmake[8]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/extensions/inspector/resources/locale'
gmake[7]: *** [all] Error 2
gmake[7]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/extensions/inspector/resources/locale'
gmake[6]: *** [libs] Error 2
gmake[6]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/extensions/inspector/resources'
gmake[5]: *** [libs] Error 2
gmake[5]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/extensions/inspector'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/extensions'
gmake[3]: *** [libs_tier_99] Error 2
gmake[3]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla'
gmake[2]: *** [tier_99] Error 2
gmake[2]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla'
gmake[1]: *** [alldep] Error 2
gmake[1]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla'
gmake: *** [alldep] Error 2
Build Error Log


 Skipping 7109 Lines...

  adding: locale/cs-CZ/inspector/search/junkImgs.dtd (stored 0%)
+++ overriding locale/cs-CZ/inspector/contents.rdf locale/cs-CZ/inspector/viewers/dom.dtd locale/cs-CZ/inspector/viewers/domNode.dtd locale/cs-CZ/inspector/viewers/styleRules.dtd locale/cs-CZ/inspector/viewers/stylesheets.dtd locale/cs-CZ/inspector/viewers/xblBindings.dtd locale/cs-CZ/inspector/viewers/boxModel.dtd locale/cs-CZ/inspector/viewers/computedStyle.dtd locale/cs-CZ/inspector/viewers/jsObject.dtd locale/cs-CZ/inspector/inspector.properties 
  adding: locale/cs-CZ/inspector/contents.rdf (stored 0%)
  adding: locale/cs-CZ/inspector/viewers/dom.dtd (stored 0%)
  adding: locale/cs-CZ/inspector/viewers/domNode.dtd (stored 0%)
  adding: locale/cs-CZ/inspector/viewers/styleRules.dtd (stored 0%)
  adding: locale/cs-CZ/inspector/viewers/stylesheets.dtd (stored 0%)
  adding: locale/cs-CZ/inspector/viewers/xblBindings.dtd (stored 0%)
  adding: locale/cs-CZ/inspector/viewers/boxModel.dtd (stored 0%)
  adding: locale/cs-CZ/inspector/viewers/computedStyle.dtd (stored 0%)
  adding: locale/cs-CZ/inspector/viewers/jsObject.dtd (stored 0%)
  adding: locale/cs-CZ/inspector/inspector.properties (stored 0%)
Comparing cs-CZ to en-US
Entities in ./inspector.dtd don't match:
  In ./en-US: (add these keys to you localization)
    mnInspectDocument.label
    mnInspectDocument.accesskey
    cmdToggleChrome.label
    cmdToggleChrome.accesskey
  In ./cs-CZ: (remove these keys from your localization)
    mnWindows.label
    mnWindows.accesskey

Properties in ./inspector.properties don't match:
  In ./en-US: (add these to your localization)
    inspectWindow.noDocuments.message
  In ./cs-CZ: (remove these from your localization)
    inspectWindow.error.message
    inspectWindow.error.title

gmake[8]: *** [libs] Error 1
gmake[8]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/extensions/inspector/resources/locale'
gmake[7]: *** [all] Error 2
gmake[7]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/extensions/inspector/resources/locale'
gmake[6]: *** [libs] Error 2
gmake[6]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/extensions/inspector/resources'
gmake[5]: *** [libs] Error 2
gmake[5]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/extensions/inspector'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla/extensions'
gmake[3]: *** [libs_tier_99] Error 2
gmake[3]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla'
gmake[2]: *** [tier_99] Error 2
gmake[2]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla'
gmake[1]: *** [alldep] Error 2
gmake[1]: Leaving directory `/builds/tinderbox/Fx-Trunk/Linux_2.4.21-27.0.4.ELsmp_Depend/mozilla'
gmake: *** [alldep] Error 2
No More Errors

Expected Results: some hint in the error message as to what makefile i need to change to make the problem go away. locale/Makefile.in didn't have the list which surprised me.

Comment 1

[Benjamin Smedberg]

http://lxr.mozilla.org/mozilla/source/extensions/inspector/resources/Makefile.in#47

When patching inspector you should remove all the non-en-US locales from that list and post to m.d.l10n for localizers to fix and re-add their locales.

You're welcome to add a comment or a clearer error message to that effect.

Comment 2

[Gregory Szorc [:gps]]

I'm pretty sure this has to do with processes from over a decade ago that are no longer practiced.