331221 - tinderbox should continue if permission change on unrelated file failed

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Tinderbox, defect)

Description

[Robert Kaiser]

I noticed today that my "tpol" tinderbox (SeaMonkey, Windows) did upload its builds to the dated directory but not the latest-* directory.

The log did show up the following lines after correctly uploading to the dated dir:
-------------
ssh -2 -l kairo stage.mozilla.org chmod -R 775 /data/ftp/pub/seamonkey/nightly/contrib/2006-03-21-03-mozilla1.8.0
chmod: changing permissions of `/data/ftp/pub/seamonkey/nightly/contrib/2006-03-21-03-mozilla1.8.0/seamonkey-1.0.1.en-US.os2.zip': Operation not permitted
command failed!
-------------
The full log is at http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla1.8.0-SeaMonkey/1142937960.24953.gz&fulltext=1

What happened is that the dir already contained the OS/2 build, then the Windows tinderbox added its builds but had no permission to change permissions on the OS/2 build and stopped.
That error wouldn't be fatal at all though, and it actually should have continued and have added the files to latest-* as well.

Probably we should either make that error non-fatal (I don't know how failing to change permissions should be fatal any time) or only apply that command to the files we really uploaded.

Comment 1

[Mark Mentovai]

In my opinion, tinderbox should set the file mode locally and transfer with scp -p or, better yet, rsync -a.  I talked about this with Chase once, and it's certainly possible to reduce the number of network round-trips.

Comment 2

[Robert Kaiser]

I think tinderbox client is very much dead nowadays, and as I filed this one I dare to WONTFIX it as well :)