331222 - context menu search does not observe browser.tabs.loadInBackground setting; always opens in foreground

Status: RESOLVED FIXED

(Firefox :: Search, defect, P2)

Description

[mmortal03]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060320 Firefox/1.6a1 ID:2006032009

The new Search bar code, which includes a new "Search [Selected Engine] For" context menu option, doesn't observe browser.tabs.loadInBackground setting anymore, and always opens in foreground.

Reproducible: Always

Steps to Reproduce:

Comment 1

[mmortal03]

Please note that the listed User-Agent build is not the build containing the bug.

Please file this bug against [e-mail].

Comment 2

[:Gavin Sharp [email: [e-mail]]]

You're talking specifically about context menu search, right?

Comment 3

[Mike Connor [:mconnor]]

So, hrm, we always opened context search in the background, it was explicitly called like that since pre 0.7.  We've never observed a pref for the searchbar or for context search, though we should think about that (and which pref to observe)

At the minimum, we should restore the 1.5 behaviour for alt-enter in the searchbar and context search.

Comment 4

[Phil Ringnalda (:philor)]

Since Gavin was just fixing it, not implementing it, in bug 276318, I think we have actually observed the pref for context search.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Ah, yeah, my patch did regress context menu search obeying the pref, patch for that in a sec. I'm not sure whether this behavior needs tweaking any further - I'll have to think about that.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch to revert to previous behavior

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js 	1.594
mozilla/browser/base/content/browser.js 	1.479.2.98

Comment 8

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060327 Firefox/1.6a1 ID:2006032721

seems to be fixed.

Comment 9

[Phil Ringnalda (:philor)]

*** Bug 332805 has been marked as a duplicate of this bug. ***

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Bug 331522 regressed this. I'll fix that once bug 334776 is fixed.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

This bug as summarized is fixed now. mconnor: was there something else you wanted to deal with in this bug? I'm not sure what the dependency on bug 324604 is for.

Comment 12

[Mike Connor [:mconnor]]

THis is probably fixed now, but I wanted it linked so I was able to follow up in the consistency review.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Ok, fixed+fixed1.8.1 then.