331274 - Lightning xpi builds should follow Mozilla package filename conventions

Status: RESOLVED INVALID

(Calendar :: Build Config, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: 0.1

Lightning 0.1 xpi files do not follow the package naming conventions, so for example the linux xpi looks like it will install on any linux platform, but in fact it contains compiled binaries that are different for each platform.

http://developer.mozilla.org/en/docs/Package_Filename_Convention

Reproducible: Always

Steps to Reproduce:
Examine Lightning xpi filenames

Actual Results:  
lightning-0.1-linux.xpi
lightning-0.1-mac-powerpc.xpi
lightning-0.1-windows.xpi

Expected Results:  
Follow same package filename convention as other Mozilla products.
http://developer.mozilla.org/en/docs/Package_Filename_Convention

After "lightning-0.1", name should be the same as the version of thunderbird it is compatible with.  Looking at 
http://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/latest-mozilla1.8/
I guess this would be

lightning-0.1.en-US.linux-i686.xpi
lightning-0.1.en-US.mac-powerpc.xpi (or mac-ppc)
lightning-0.1.en-US.win32.xpi

(assuming plain mac contains both ppc and x86, fat binaries?)


Someone misled by filename:  Bug 331251 comment 0.

This also applies to nightlies.

Comment 1

[Stefan Sitter [:ssitter]]

Just a quick thought: This Package File-naming Convention is meant for XUL Toolkit Applications but not even Firefox or Thunderbird follow this guideline. Instead they use a directory structure like
mozilla.org\firefox\releases\1.5\win32\en-US\ or
mozilla.org\firefox\releases\1.5\linux-i686\en-US\

Also I don't know how the plans look for Lightning but an extension can contain multiple languages in one xpi file.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

We use directories just as everyone else does, which sufficient. The files get renamed on AMO anyway, and I think directories make things clear enough.