331307 - Bookmarks toolbar chevron is left-aligned instead of right-aligned

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Phil Ringnalda (:philor)]

I'd almost like to see this wontfixed, since it's arguably better UI to drop things that will wind up in the overflow anyway in a space to the right of the chevron, rather than think you are dropping them in the space between the last item and the chevron only to have them disappear, but since a random late-January build had a right-aligned chevron I'd guess it's just CSS that got lost somewhere, maybe in the dismantling of the places shim.

Comment 1

[Phil Ringnalda (:philor)]

*** Bug 333384 has been marked as a duplicate of this bug. ***

Comment 2

[Martijn Wargers (dead)]

Attachment: patch

This fixes it. I removed the <vbox>, because it doesn't seem to do anything useful. If it's needed, then it needs to have flex="1" as attribute.

Comment 3

[Martijn Wargers (dead)]

Attachment: diff -w

Comment 4

[Ed Hume]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060421 BonEcho/2.0a1 - Build ID: 2006042114 -

On my system, this bug is fixed when the deletions in patch 219367 are applied to browser.jar/content/browser/places/toolbar.xml. 

With default and two different non-default themes, the chevron adheres to the right margin.

Comment 5

[Ed Hume]

There is still a problem. Using the deletions from the patch, when there is just enough content on the bookmarks toolbar, the chevron is partway off the screen.

Screenshot:

http://img525.imageshack.us/img525/2249/overflow1kk.png

This problem can occur without the patch deletions as well. Deleting the pack="end" (in the hbox that mentions mousethrough) does not fix the overhang problem.

If this needs a separate bug, please let me know.

Comment 6

[Annie Sullivan]

(In reply to comment #2)
> Created an attachment (id=219366) [edit]
> patch
> 
> This fixes it. I removed the <vbox>, because it doesn't seem to do anything
> useful. If it's needed, then it needs to have flex="1" as attribute.

Does drag and drop visual feedback still look the same with the <vbox> removed?

Comment 7

[Ed Hume]

> Does drag and drop visual feedback still look the same with the <vbox> removed?

Drag and drop visual feedback is horked with the <vbox> removed.

Comment 8

[Ed Hume]

I don't know if this will help, but as of this build - 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2 - Build ID: 2006030804 - 

the chevron is now right-aligned again.

I suspect that it is no coincidence that Places was backed out.

Comment 10

[Steve Won (stevewon on irc)]

Attachment: Patch

Patch.

I think what was happening before was that, the vbox that contains the chevron isn't wide enough to reach the end of the toolbar. So even though there was " "pack='end'" and the chevron was right-aligned to the vbox, it looked like the chevron was left-aligned.

I just moved the chevron hbox (http://mxr.mozilla.org/mozilla/source/browser/components/places/content/toolbar.xml#67) out of the vbox, so pack="end" is relative to bookmarksBarContent (http://mxr.mozilla.org/mozilla/source/browser/base/content/browser.xul#332).

The drag + drop problem mentioned doesn't occur in this patch. Also not able to reproduce the chevron being partly cutoff with this patch yet.

Comment 11

[Asaf Romano (gone)]

Comment on attachment 270655 [details] [diff] [review]
Patch

not that the containing vbox or the hbox->hbox crap makes sense, but this is good to go.

r=mano.

Comment 12

[(not reading, please use [e-mail] instead)]

fixed landed.

Checking in toolbar.xml;
/cvsroot/mozilla/browser/components/places/content/toolbar.xml,v  <--  toolbar.x
ml
new revision: 1.99; previous revision: 1.98
done

Comment 13

[(not reading, please use [e-mail] instead)]

steve, can you elaborate on what the "drag + drop" problem was?

Comment 14

[Steve Won (stevewon on irc)]

I was referring to Comment #6.
If vbox was removed like the earlier patches, then drag+drop onto the toolbar would result in a weird behavior.

Comment 15

[(not reading, please use [e-mail] instead)]

steve, what was the weird behaviour?

Comment 16

[Steve Won (stevewon on irc)]

Entire bookmarks toolbar would slide down to the right. Eventually, the bookmarks toolbar would seem empty.

Comment 17

[(not reading, please use [e-mail] instead)]

> Entire bookmarks toolbar would slide down to the right. Eventually, the
> bookmarks toolbar would seem empty.

Thanks Steve.  

I'm not seeing the weird behaviour (with your patch) on trunk / windows xp.

Comment 18

[Tracy Walker [:tracy]]

verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071705 Minefield/3.0a7pre

Comment 19

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv