331368 - Spellchecker errors on in content iterator

Status: RESOLVED FIXED

(Core :: Spelling checker, defect, P1)

Description

[Brett Wilson]

WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file /usr/local/google/home/brettw/branchspell/mozilla/editor/txtsvc/src/nsFilteredContentIterator.cpp, line 110
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(res)) failed, file /usr/local/google/home/brettw/branchspell/mozilla/extensions/spellcheck/src/mozInlineSpellChecker.cpp, line 999

Comment 1

[Brett Wilson]

Attachment: Patch

The problem was that the range would be an empty range on the document DOM element, which would then fail when we tried to create an iterator for it.

The code checks to see if the range is collapsed, but then doesn't do anything with the value. I added a check and return if it is collapsed.

I'm a little unsure about this. Is this the proper thing? Can we have a collapsed range in the middle of a word and does that mean we need to spellcheck the word?

I didn't see any problems in using it with this patch applied.

Comment 2

[Brett Wilson]

Gavin: why did you cancel the review request?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Sorry, the component move canceled the request, and Bugzilla didn't tell me (bug 274802).

Comment 4

[Scott MacGregor]

Comment on attachment 215920 [details] [diff] [review]
Patch

I think this should be ok.

Comment 5

[Brett Wilson]

Fixed on trunk. Leaving open so I don't forget to check into branch.

Comment 6

[Brett Wilson]

Fixed on branch.