Closed
Bug 331625
Opened 19 years ago
Closed 18 years ago
nsIDOMXULSelectControlElement needs an itemCount property
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: enndeakin, Assigned: enndeakin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
25.99 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
For bug 331505, nsIDOMXULSelectControlElement needs to have an itemCount property. Also, might as well add getItemAtIndex/getIndexOfItem methods too.
|
Assignee | |
Comment 2•18 years ago
|
||
Also converts the usage in insertItemAt/removeItemAt to use them.
Attachment #255345 -
Flags: superreview?(neil)
Attachment #255345 -
Flags: review?(neil)
|
||
Comment 3•18 years ago
|
||
Comment on attachment 255345 [details] [diff] [review]
add itemCount/getIndexOfItem/getItemAtIndex to interface
>+ return this._getRadioChildren()[index] || null;
I feel this is unsafe; someone could pass in hidden properties.
I'd prefer to see a range check on index rather than the || null trick.
>+ this.mRadioChildren = null;
Well, ideally our xbl would do this... once it gets bound...
Attachment #255345 -
Flags: superreview?(neil)
Attachment #255345 -
Flags: superreview+
Attachment #255345 -
Flags: review?(neil)
Attachment #255345 -
Flags: review+
|
|
Assignee | |
Comment 4•18 years ago
|
||
Tests will be part of bug 368097. Specific test can be found at http://www.xulplanet.com/ndeakin/tests/xts/misc/select.xul
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
|
|
Assignee | |
Updated•14 years ago
|
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•